Test/handler/score #182
Open
Test/handler/score #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "github.com/su-its/typing/typing-server/internal/domain/service" | ||
| ) | ||
|
|
||
| // モック作成のためインターフェースを実装 |
Member
There was a problem hiding this comment.
インターフェースの作成は正確にはモック作成のためではなく、インタフェースという抽象の具体の一つにモックがあるという認識できると 良いです。
Member
There was a problem hiding this comment.
インターフェースなことは見ればわかりそうなのでコメントなくても良さそう
Comment on lines
+12
to
+13
| // モック作成のためインターフェースを実装 | ||
| type IScoreUseCase interface { |
Member
There was a problem hiding this comment.
Suggested change
| // モック作成のためインターフェースを実装 | |
| type IScoreUseCase interface { | |
| type IScoreUseCase interface { |
Comment on lines
+23
to
+35
| const ( | ||
| ErrMsgInvalidSortbyParam = "Invalid sort_by parameter" | ||
| ErrMsgInvalidStartParam = "Invalid start parameter" | ||
| ErrMsgInvalidLimitParam = "Invalid limit parameter" | ||
| ErrMsgFetchRanking = "Failed to fetch ranking" | ||
| ErrMsgScoreEncodeResponse = "Failed to encode response" | ||
|
|
||
| ErrMsgInvalidReqBody = "Invalid request body" | ||
| ErrMsgInvalidUserIdFormat = "Invalid user_id format" | ||
| ErrMsgRegisterScore = "Failed to register score" | ||
| MsgRegisteredSuccessfully = "Score registered successfully" | ||
| ErrMsgWriteResponse = "Failed to write response" | ||
| ) |
Member
There was a problem hiding this comment.
日本語で対応したいかもですね。
これはUserHandlerが日本語に対応しているからなのですが。
KinjiKawaguchi
requested changes
Feb 25, 2025
| "github.com/su-its/typing/typing-server/internal/domain/service" | ||
| ) | ||
|
|
||
| // モック作成のためインターフェースを実装 |
Member
There was a problem hiding this comment.
インターフェースなことは見ればわかりそうなのでコメントなくても良さそう
KinjiKawaguchi
force-pushed
the
test/handler/score
branch
from
5533464 to
c3c9b37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケットへのリンク
やったこと
やらないこと
できるようになること（ユーザ目線）
できなくなること（ユーザ目線）
動作確認
その他