Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Upgraded the
@adobe/css-tools
dependency to include the fix for parsing the@starting-style
CSS feature, which was causing a "missing '}'" error.Why:
The current version of
@adobe/css-tools
used byjest-styled-components
fails to parse the@starting-style
CSS feature, resulting in a parsing error. The upgrade includes a fix for this issue, allowing for the correct parsing of CSS files using@starting-style
.How:
The changes were implemented by updating the
package.json
file to use the latest version of@adobe/css-tools
, which includes the fix from the PR I submitted to@adobe/css-tools
(adobe/css-tools#323).Additional Comments:
Unfortunately, I could not add a test case for the
@starting-style
feature becausejsdom 20
usesCSSOM
for CSS parsing, which also has a similar issue. I submitted a PR to fix this issue inCSSOM
(rrweb-io/CSSOM#1), but the latest version ofjsdom
cannot be merged intojest-environment-jsdom
to maintain Node 16 support.For reference, I have already submitted a similar PR to
testing-library/jest-dom
addressing the same issue: testing-library/jest-dom#602.