Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for @starting-style #446

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jantimon
Copy link
Contributor

@jantimon jantimon commented Jun 5, 2024

What:

Upgraded the @adobe/css-tools dependency to include the fix for parsing the @starting-style CSS feature, which was causing a "missing '}'" error.

Why:

The current version of @adobe/css-tools used by jest-styled-components fails to parse the @starting-style CSS feature, resulting in a parsing error. The upgrade includes a fix for this issue, allowing for the correct parsing of CSS files using @starting-style.

How:

The changes were implemented by updating the package.json file to use the latest version of @adobe/css-tools, which includes the fix from the PR I submitted to @adobe/css-tools (adobe/css-tools#323).

Additional Comments:

Unfortunately, I could not add a test case for the @starting-style feature because jsdom 20 uses CSSOM for CSS parsing, which also has a similar issue. I submitted a PR to fix this issue in CSSOM (rrweb-io/CSSOM#1), but the latest version of jsdom cannot be merged into jest-environment-jsdom to maintain Node 16 support.

For reference, I have already submitted a similar PR to testing-library/jest-dom addressing the same issue: testing-library/jest-dom#602.

Copy link
Member

@christiansany christiansany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests green and locally tested by Jan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants