🐛 Change CORS layer construction to allow wildcard #538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the problem raised in #537, which causes Stump to fail to start when a wildcard ("*") is used in the allowed origins configuration variable.
The cause is that Axum doesn't like wildcards being added via the
AllowOrigin::list()
function and wants you to useAllowOrigin::any()
instead. I slightly reorganized the server'sget_cors_layer()
function to detect when a "*" is present in the list of allowed origins and exit early with anAllowOrigin::any()
configuration.I'm making the assumption is that there is no case where the allowed origin list would include a wildcard and then other origins but the user would expect behavior other than any origin being allowed. I think that's right.