β¨ render children of an epub content item #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll be able to take a look tomorrow after work to review, but based on your screenshot I actually think this would resolve #334! Excited to give it a proper look! Thank you! |
Codecov ReportAttention: Patch coverage is
|
aaronleopold
approved these changes
Dec 11, 2024
| @@ -14,6 +14,7 @@ use super::{media::Media, MediaAnnotation}; | |||
| pub struct EpubContent { | |||
| label: String, | |||
| content: PathBuf, | |||
| children: Vec<EpubContent>, | |||
There was a problem hiding this comment.
I'm surprised that clippy didn't complain about this recursive type, but I won't complain about it not complaining about it π
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some epub content items have more content items inside! This PR exposes them to the reader.
First time working with Rust π - criticism welcome!
Before
After