Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Manage mutation-testing-elements with renovate #2902

Merged
merged 7 commits into from
Sep 13, 2024

Conversation

hanahbaker1
Copy link
Contributor

@hanahbaker1 hanahbaker1 commented Apr 4, 2024

Adding custom manager for libman in renovate config file
fixes #2862

initial thoughts on adding custom manager for libman in renovate config file
@rouke-broersma rouke-broersma changed the title Update renovate.json deps: Manage mutation-testing-elements with renovate Apr 12, 2024
@rouke-broersma
Copy link
Member

@hanahbaker1 apparently for renovate to validate the change the branch must be named renovate/reconfigure. I've copied your change to a new branch with that name and the validation seems to be failing. I had expected some kind of error message from renovate that explains what's wrong but so far I haven't found any. See: #2910

Seems like something in the configuration is incorrect.

@rouke-broersma
Copy link
Member

Ok I ran the validator locally and this is the output:

> RENOVATE_CONFIG_FILE=renovate.json

> npx -p renovate renovate-config-validator

 INFO: Validating renovate.json
ERROR: Found errors in configuration
       "file": "renovate.json",
       "errors": [
         {
           "topic": "Configuration Error",
           "message": "Custom Manager contains disallowed fields: depName"
         },
         {
           "topic": "Configuration Error",
           "message": "Invalid configuration option: customManagers[0].depName"
         }
       ]

Copy link
Member

@rouke-broersma rouke-broersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config is not quite valid. You can validate the config using the following commands on linux:

> cd stryker-net/.github
> RENOVATE_CONFIG_FILE=renovate.json
> npx -p renovate renovate-config-validator

Let me know if you need any help with that

@rouke-broersma rouke-broersma merged commit 9e643b1 into stryker-mutator:master Sep 13, 2024
2 of 3 checks passed
@rouke-broersma
Copy link
Member

Thanks for the assist @hanahbaker1! Much appreciated :) Sorry it took me so long to get back around to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom renovate config for parsing libman.json for mutation-testing-elements updates
2 participants