Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default TLS protocol version in the config file #429

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

leonklingele
Copy link
Contributor

Copy link
Contributor

@longsleep longsleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhm, this most likely should also include a change in the dependencies.tsv to pull in a newer minimal version of phoenix. I suggest that you also remove the mentioning of SSLv3 making TLSv1 the minimal version. Though the first Go version where it actually can be recommended to run the server with its native TLS listener is Go 1.8.

@leonklingele
Copy link
Contributor Author

@longsleep Should I completely remove support for SSLv3 from phoenix or only the references in the Spreed WebRTC config file?

@longsleep
Copy link
Contributor

@longsleep Should I completely remove support for SSLv3 from phoenix or only the references in the Spreed WebRTC config file?

Just remove the reference in the config file and bump dependencies.tsv to the latest release of phoenix. Also make sure to check that minimal Go version for phoenix does conflict with that used here.

@leonklingele
Copy link
Contributor Author

leonklingele commented May 13, 2017

Updated. dependencies.tsv already points to the latest phoenix release commit (strukturag/phoenix@8c65e16).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants