-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix installing de265-version.h with CMake #276
base: master
Are you sure you want to change the base?
Conversation
This might conflict with b415d34. |
Hm, I've tried your command line for reproducing the issue, but it works fine for me (Ubuntu 18.04). The de265-version.h is installed correctly. |
90255e2
to
63a3449
Compare
First part of the problem (installing de265-version.h) was already fixed in commit a49dc4e (released in 1.0.8) so I am dropping this part. Second part of the problem (see error below) is reproduced using the command in description (make sure to remove created dirs) and is addressed in a new version of PR:
|
Build failure is due to Homebrew timeout. I can bump PR if it is needed. |
This affects me on Windows, using VS 2019. I can confirm that applying the proposed change fixes the issue for me. |
I wonder why |
it is needed for MSVC builds (see |
63a3449
to
e2ddfc7
Compare
File
de265-version.h
cannot be properly installed in out-of-source builds because it is listed inlibde265_headers
.Reproducing: