Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installing de265-version.h with CMake #276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

theirix
Copy link
Contributor

@theirix theirix commented Oct 31, 2020

File de265-version.h cannot be properly installed in out-of-source builds because it is listed in libde265_headers.

Reproducing:

mkdir build && cd build && cmake -DCMAKE_INSTALL_PREFIX=/tmp/libde265-inst .. && make && make install

@farindk
Copy link
Contributor

farindk commented Nov 2, 2020

This might conflict with b415d34.

@farindk
Copy link
Contributor

farindk commented Nov 2, 2020

Hm, I've tried your command line for reproducing the issue, but it works fine for me (Ubuntu 18.04). The de265-version.h is installed correctly.

@theirix
Copy link
Contributor Author

theirix commented Nov 2, 2020

First part of the problem (installing de265-version.h) was already fixed in commit a49dc4e (released in 1.0.8) so I am dropping this part.

Second part of the problem (see error below) is reproduced using the command in description (make sure to remove created dirs) and is addressed in a new version of PR:

Install the project...
-- Install configuration: ""
-- Installing: /tmp/libde265-inst/lib/liblibde265.dylib
-- Installing: /tmp/libde265-inst/include/libde265/acceleration.h
-- Installing: /tmp/libde265-inst/include/libde265/alloc_pool.h
-- Installing: /tmp/libde265-inst/include/libde265/bitstream.h
-- Installing: /tmp/libde265-inst/include/libde265/cabac.h
-- Installing: /tmp/libde265-inst/include/libde265/configparam.h
CMake Error at libde265/cmake_install.cmake:54 (file):
  file INSTALL cannot find
  "/Users/irix/projects/libs/libde265/libde265/de265-version.h": No such file
  or directory.
Call Stack (most recent call first):
  cmake_install.cmake:42 (include)

@theirix
Copy link
Contributor Author

theirix commented Nov 3, 2020

Build failure is due to Homebrew timeout. I can bump PR if it is needed.

@ArturKovacs
Copy link

This affects me on Windows, using VS 2019. I can confirm that applying the proposed change fixes the issue for me.

@igo95862
Copy link

I wonder why extra/libde265/de265-version.h exists..

@theirix
Copy link
Contributor Author

theirix commented Jan 29, 2023

I wonder why extra/libde265/de265-version.h exists..

it is needed for MSVC builds (see libde265/Makefile.vc7) which do not generate de265-version.h by the call to configure_file on Linux/macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants