-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create consumer session before verification pane #9032
Draft
tillh-stripe
wants to merge
2
commits into
master
Choose a base branch
from
tillh/create-consumer-session-before-verification-pane
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Create consumer session before verification pane #9032
tillh-stripe
wants to merge
2
commits into
master
from
tillh/create-consumer-session-before-verification-pane
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diffuse output:
APK
|
tillh-stripe
force-pushed
the
tillh/create-consumer-session-before-verification-pane
branch
5 times, most recently
from
August 12, 2024 13:56
a2b1376
to
02c0a1c
Compare
tillh-stripe
force-pushed
the
tillh/create-consumer-session-before-verification-pane
branch
from
August 13, 2024 21:36
02c0a1c
to
c7f078c
Compare
tillh-stripe
force-pushed
the
tillh/instant-debits-nux
branch
from
August 14, 2024 14:50
dba999b
to
ecf6091
Compare
tillh-stripe
force-pushed
the
tillh/create-consumer-session-before-verification-pane
branch
from
August 15, 2024 13:23
34432fe
to
647da7e
Compare
Comment on lines
+12
to
+17
sealed interface Result { | ||
data class Success(val consumerSession: ConsumerSession) : Result | ||
data object ConsumerNotFound : Result | ||
data class LookupError(val error: Throwable) : Result | ||
data class VerificationError(val error: Throwable) : Result | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ much better.
Comment on lines
+119
to
121
loadingPrimary: Boolean, | ||
loading: Boolean, | ||
secondaryButtonLabel: Int, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit - these 3 are not named consistently. Maybe something like:
Suggested change
loadingPrimary: Boolean, | |
loading: Boolean, | |
secondaryButtonLabel: Int, | |
primaryButtonLoading: Boolean, | |
footerLoading: Boolean, | |
secondaryButtonLabel: Int, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing
Screenshots
Changelog