Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create consumer session before verification pane #9032

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tillh-stripe
Copy link
Collaborator

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├─────────────┬─────────────┬──────┼─────────────┬─────────────┬──────
 APK      │ old         │ new         │ diff │ old         │ new         │ diff 
──────────┼─────────────┼─────────────┼──────┼─────────────┼─────────────┼──────
      dex │       2 MiB │       2 MiB │  0 B │     4.2 MiB │     4.2 MiB │  0 B 
     arsc │ 1,023.9 KiB │ 1,023.9 KiB │  0 B │ 1,023.8 KiB │ 1,023.8 KiB │  0 B 
 manifest │     2.3 KiB │     2.3 KiB │  0 B │       8 KiB │       8 KiB │  0 B 
      res │   301.5 KiB │   301.5 KiB │  0 B │     455 KiB │     455 KiB │  0 B 
   native │     6.2 MiB │     6.2 MiB │  0 B │    15.8 MiB │    15.8 MiB │  0 B 
    asset │     6.7 KiB │     6.7 KiB │  0 B │     6.5 KiB │     6.5 KiB │  0 B 
    other │    85.5 KiB │    85.5 KiB │ +5 B │   158.7 KiB │   158.7 KiB │  0 B 
──────────┼─────────────┼─────────────┼──────┼─────────────┼─────────────┼──────
    total │     9.6 MiB │     9.6 MiB │ +5 B │    21.6 MiB │    21.6 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21305 │ 21305 │ 0 (+0 -0) 
   types │  6770 │  6770 │ 0 (+0 -0) 
 classes │  5559 │  5559 │ 0 (+0 -0) 
 methods │ 31123 │ 31123 │ 0 (+0 -0) 
  fields │ 18141 │ 18141 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3392 │ 3392 │  0
APK
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
    272 B │ +3 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 28.3 KiB │ +3 B │  62.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │ -2 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
 25.1 KiB │ +1 B │  62.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 54.9 KiB │ +5 B │ 126.4 KiB │  0 B │ (total)

@tillh-stripe tillh-stripe force-pushed the tillh/create-consumer-session-before-verification-pane branch 5 times, most recently from a2b1376 to 02c0a1c Compare August 12, 2024 13:56
@tillh-stripe tillh-stripe changed the base branch from master to tillh/instant-debits-nux August 13, 2024 20:55
@tillh-stripe tillh-stripe force-pushed the tillh/create-consumer-session-before-verification-pane branch from 02c0a1c to c7f078c Compare August 13, 2024 21:36
Base automatically changed from tillh/instant-debits-nux to master August 14, 2024 17:32
@tillh-stripe tillh-stripe force-pushed the tillh/create-consumer-session-before-verification-pane branch from 34432fe to 647da7e Compare August 15, 2024 13:23
Comment on lines +12 to +17
sealed interface Result {
data class Success(val consumerSession: ConsumerSession) : Result
data object ConsumerNotFound : Result
data class LookupError(val error: Throwable) : Result
data class VerificationError(val error: Throwable) : Result
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ much better.

Comment on lines +119 to 121
loadingPrimary: Boolean,
loading: Boolean,
secondaryButtonLabel: Int,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - these 3 are not named consistently. Maybe something like:

Suggested change
loadingPrimary: Boolean,
loading: Boolean,
secondaryButtonLabel: Int,
primaryButtonLoading: Boolean,
footerLoading: Boolean,
secondaryButtonLabel: Int,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants