in plot_type_int, allow transformed interaction terms

[jczimm]

Closes #940

insight::clean_names internally uses insight::trim_ws at the end, so it can cleanly replace sjmisc::trim

[gemini-code-assist]

Summary of Changes

Hello @jczimm, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors an internal string cleaning utility within the plot_type_int function. By updating the dependency from sjmisc::trim to insight::clean_names, the function gains the ability to properly handle and plot interaction terms that have been transformed, thereby enhancing its overall functionality and reliability.

Highlights

• Refactoring and Dependency Update: The plot_type_int function now uses insight::clean_names instead of sjmisc::trim for processing interaction terms. This change aligns with modern insight package practices and leverages clean_names's internal whitespace trimming capabilities.
• Enhanced Interaction Term Handling: This update specifically enables the plot_type_int function to correctly parse and plot transformed interaction terms, addressing a previous limitation and improving the robustness of the plotting utility.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request replaces sjmisc::trim with insight::clean_names in plot_type_int to handle transformed interaction terms better. The main concern is that insight::clean_names transforms term names, which could cause issues when accessing columns in the model's data frame. Clarification and a test case are requested to ensure compatibility.