-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add words from my project #3846
base: main
Are you sure you want to change the base?
Conversation
@@ -4552,6 +4554,7 @@ dashier | |||
dashpots | |||
dashy | |||
dataflow | |||
datacenter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have moved it to software dicts
But why not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is more of a coding term. data center
is two words in standard English. Please add it as dataCenter
to dictionaries/software-terms/src/coding-terms.txt
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a place where you documented the way to add words?
I'm talking about here the special case "dataCenter", sometimes there is a need to use ^
right?
I'm curious
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is more of a coding term.
data center
is two words in standard English. Please add it asdataCenter
todictionaries/software-terms/src/coding-terms.txt
.
Is there a need to add the plural? So dataCenters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a place where you documented the way to add words?
You make a good point. I'm not sure if there is a good explanation.
`
I'm talking about here the special case "dataCenter"?
I suggest using dataCenter
because normally it is two words. The software terms dictionary will generate dataCenter
and ~datacenter
. datacenter
gets used when the spell checking is not case sensitive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not asking to add ~datacenter
only?
I mean why is there a need for an uppercased C
I would love if you add a clear documentation.
It would help me to contribute. I have a lot of words from my personal projects too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not asking to add
~datacenter
only?
That would also work.
I mean why is there a need for an uppercased
C
I want to find out what words are commonly compounded to build a compound dictionary.
This was done with CPP. It allows things like allocatebug
since the dictionary contains *allocate*
and *bug*
.
I would love if you add a clear documentation.
I could use some help with documentation.
It would help me to contribute. I have a lot of words from my personal projects too
That would be awesome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So @virzak
If we move discussion out, here you should add datacenter and datacenters to coding-terms dictionary
The syntax suggested is
dataCenter
dataCenters
As it helps to inform about the fact it's a compound words.
@@ -18369,6 +18374,7 @@ signiori | |||
signiories | |||
signiors | |||
signiory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is also a software terms to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing.
Please adjust the location of the words based upon the comments.
@@ -4552,6 +4554,7 @@ dashier | |||
dashpots | |||
dashy | |||
dataflow | |||
datacenter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is more of a coding term. data center
is two words in standard English. Please add it as dataCenter
to dictionaries/software-terms/src/coding-terms.txt
.
@@ -4095,6 +4095,8 @@ counterinsurgents | |||
countermaid | |||
counteropening | |||
counterphobic | |||
counterparties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please counterparty
and counterparties
to dictionaries/en_shared/src/shared-additional-words.txt
.
@@ -16910,6 +16914,7 @@ resurging | |||
ret | |||
retailor | |||
retailors | |||
retainage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please retainage
to dictionaries/en_shared/src/shared-additional-words.txt
.
@@ -16807,6 +16810,7 @@ republica | |||
repugnancy | |||
repulser | |||
repulsers | |||
reputational |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reputational
to dictionaries/en_shared/src/shared-additional-words.txt
.
@@ -18369,6 +18374,7 @@ signiori | |||
signiories | |||
signiors | |||
signiory | |||
signoff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be sign-off
, which is already in the dictionary.
@@ -20411,6 +20417,7 @@ tiltable | |||
tilters | |||
timbals | |||
timberlands | |||
timeframe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
time frame
is two words.
As a single word, it is more of a coding term. Please add it as timeFrame
to dictionaries/software-terms/src/coding-terms.txt
.
Add/Fix Dictionary
Dictionary: en-us
Description
A few words from a document
Checklist
fix:
- for minor changes like adding words or fixing spelling issues.feat:
- for a significant change like adding a whole new set of words to a dictionary.feat!:
- for breaking changes, like file format or licensing changes.chore:
- for changes that do not impact the content of dictionaries.