Handle streets where the name overlaps the street-type map #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some addresses like 14168 W RIVER RD COLUMBIA STATION, OH 44028-9430 are interpreted with the street being "W", the street type as "River" (which abbreviates to "riv"), and the city as "RD \nCOLUMBIA STATION". The example addresses are all in Ohio because that's my current dataset, but it's not an Ohio-specific phenomenon: for example, in Illinois, there's a River Road that follows the Des Plaines River. The erroneous parse appears to be from the "100 South Street" special case in the street regexp. This commit adds a second special case with higher precedence, matching [prefix, non-numeric street, street type] sequences. The street match excludes numerics to preserve the existing parse behavior for the "6641 N 2200 W Apt D304 Park City, UT 84098" case.
|
@derrek, this seems pretty neat. |
|
Really would like to see this. "Ridge Road" suffers from this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some addresses like
are interpreted with the street being "W", the street type as "River"
(which abbreviates to "riv"), and the city as "RD \nCOLUMBIA STATION".
The example addresses are all in Ohio because that's my current data set,
but it's not an Ohio-specific phenomenon: for example, in Illinois,
there's a River Road that follows the Des Plaines River.
The erroneous parse appears to be from the "100 South Street"
special case in the street regexp. This commit adds a second special
case with higher precedence, matching [prefix, non-numeric street,
street type] sequences. The street match excludes numerics to preserve
the existing parse behavior for the "6641 N 2200 W Apt D304 Park City,
UT 84098" case.