Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Recorder is not initialized error #21 #24

Merged
merged 1 commit into from
Jan 23, 2021

Conversation

congpeijun
Copy link
Contributor

No description provided.

@congpeijun
Copy link
Contributor Author

#21 Fix this error.

@streamer45
Copy link
Owner

@congpeijun

Can you share a bit more context on this PR? The linked issue was caused by a bug in the code (now fixed).
Were you having issues with the specific command this PR touches instead? I am thinking it shouldn't really matter whether we add the slash or not to the source directory, unless there's a symlink involved, which should not be the case.

@congpeijun
Copy link
Contributor Author

congpeijun commented Jan 23, 2021

Hi, @streamer45
When add the slash, the cp command only copy the folders and files in the public folder, but when realy want the whole public folder instead.
I check the plugin starter template, and It do this also.
https://github.com/mattermost/mattermost-plugin-starter-template/blob/master/Makefile#L106

@streamer45
Copy link
Owner

@congpeijun

Thank you for added info and for the PR. I was asking because I cannot reproduce this behaviour on Linux.
The command performs the same action with or without the ending slash. Maybe it's a shell/system related issue.

Out of curiosity, on what operating system are you experiencing this?

@streamer45 streamer45 self-requested a review January 23, 2021 08:14
@streamer45 streamer45 merged commit 2e6458f into streamer45:master Jan 23, 2021
@congpeijun
Copy link
Contributor Author

@streamer45 macOS Big sur. Good news for merging, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants