Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create starlette subscriptions example #7

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jkimbo
Copy link
Member

@jkimbo jkimbo commented Sep 18, 2021

Create a subscriptions example with:

  • Subscribing to a websocket
  • A simple in memory queue system

@ossareh
Copy link

ossareh commented Oct 6, 2021

I like this! good work!

My only real critique is that it uses a few patterns (such as create_type, and the creation of module scoped things like Mutation) which are not common in the getting started guide and may result in folks thinking something like "just to get subscriptions I need to do all this other stuff".

That said, I found this pattern incredibly useful, I learned things from it - and I'm going to go and replace some of my manual grunge which accomplishes the same things with these strawberry.tools 🍓👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants