Add noise bench #2037
Merged
Add noise bench #2037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
this is one of my first times working with bench code, so I added a few conceptual questions to make sure my understanding is correct. If you have time, I’d appreciate your thoughts on them.
Also, I was able to run all the benches locally without problems @ 6011a60
plebhash
reviewed
Jan 17, 2026
plebhash
reviewed
Jan 17, 2026
plebhash
reviewed
Jan 17, 2026
plebhash
reviewed
Jan 18, 2026
Shourya742
force-pushed
the
2025-12-19-add-noise-bench
branch
2 times, most recently
from
11ba2d9 to
cf62086
Compare
plebhash
reviewed
Jan 20, 2026
Shourya742
force-pushed
the
2025-12-19-add-noise-bench
branch
from
6b7ec1d to
c69339b
Compare
Member
|
it would be good to add some words about this to the also a |
plebhash
approved these changes
Jan 21, 2026
2. Add intermediate handshake step benchmark 3. rename codec to transport
Shourya742
force-pushed
the
2025-12-19-add-noise-bench
branch
from
944c2c7 to
fc93767
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2041
This PR adds noise benches, targeting the handshake and post-handshake scenario's.