-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TemplateProvider
cleanup
#1369
base: main
Are you sure you want to change the base?
TemplateProvider
cleanup
#1369
Conversation
fa3fd22
to
94f2895
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1369 +/- ##
==========================================
+ Coverage 18.04% 24.12% +6.08%
==========================================
Files 127 82 -45
Lines 9559 6279 -3280
==========================================
- Hits 1725 1515 -210
+ Misses 7834 4764 -3070
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
94f2895
to
c991b7f
Compare
roles/tests-integration/lib/utils.rs
Outdated
let response = minreq::get(download_url).send(); | ||
match response { | ||
Ok(res) => { | ||
if res.status_code >= 200 && res.status_code < 300 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c991b7f
to
ee495f5
Compare
looks like clippy CI is breaking here |
3f204cd
to
be64cf7
Compare
I am able to deterministically reproduce this locally
|
be64cf7
to
e3d5dbf
Compare
e3d5dbf
to
5ae7eb4
Compare
Rebased without further changes |
previously we assumed only 200 is success.
5ae7eb4
to
4083ced
Compare
4083ced
to
b43c553
Compare
resolves #1368