Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TemplateProvider cleanup #1369

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jbesraa
Copy link
Contributor

@jbesraa jbesraa commented Jan 21, 2025

resolves #1368

@jbesraa jbesraa force-pushed the 2025-01-21/template-provider-cleanup branch from fa3fd22 to 94f2895 Compare January 21, 2025 13:53
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.12%. Comparing base (a8885ec) to head (b43c553).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1369      +/-   ##
==========================================
+ Coverage   18.04%   24.12%   +6.08%     
==========================================
  Files         127       82      -45     
  Lines        9559     6279    -3280     
==========================================
- Hits         1725     1515     -210     
+ Misses       7834     4764    -3070     
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_sv2-coverage 6.95% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 24.88% <ø> (ø)
codec_sv2-coverage 0.02% <ø> (ø)
common_messages_sv2-coverage 0.17% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.37% <ø> (ø)
jd_client-coverage ?
jd_server-coverage ?
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.38% <ø> (ø)
mining-coverage 3.17% <ø> (+0.02%) ⬆️
mining_device-coverage ?
mining_proxy_sv2-coverage ?
noise_sv2-coverage 5.78% <ø> (ø)
protocols 23.92% <ø> (+0.01%) ⬆️
roles ?
roles_logic_sv2-coverage 11.64% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage ?
utils 25.04% <ø> (ø)
v1-coverage 3.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbesraa jbesraa force-pushed the 2025-01-21/template-provider-cleanup branch from 94f2895 to c991b7f Compare January 30, 2025 17:05
@jbesraa jbesraa marked this pull request as ready for review January 30, 2025 17:06
let response = minreq::get(download_url).send();
match response {
Ok(res) => {
if res.status_code >= 200 && res.status_code < 300 {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbesraa jbesraa force-pushed the 2025-01-21/template-provider-cleanup branch from c991b7f to ee495f5 Compare January 30, 2025 17:08
@plebhash
Copy link
Collaborator

plebhash commented Feb 1, 2025

looks like clippy CI is breaking here

@jbesraa jbesraa force-pushed the 2025-01-21/template-provider-cleanup branch 2 times, most recently from 3f204cd to be64cf7 Compare February 10, 2025 12:36
@plebhash
Copy link
Collaborator

https://github.com/stratum-mining/stratum/actions/runs/13241002338/job/36956174262?pr=1369#step:7:576

I am able to deterministically reproduce this locally

error[E0277]: `(TemplateProvider, std::net::SocketAddr)` is not a future
  --> tests-integration/tests/jd_integration.rs:27:56
   |
27 |     let (_tp, tp_addr) = start_template_provider(None).await;
   |                          ------------------------------^^^^^
   |                          |                            ||
   |                          |                            |`(TemplateProvider, std::net::SocketAddr)` is not a future
   |                          |                            help: remove the `.await`
   |                          this call returns `(TemplateProvider, std::net::SocketAddr)`
   |
   = help: the trait `Future` is not implemented for `(TemplateProvider, std::net::SocketAddr)`
   = note: (TemplateProvider, std::net::SocketAddr) must be a future or must implement `IntoFuture` to be awaited
   = note: required for `(TemplateProvider, std::net::SocketAddr)` to implement `IntoFuture`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `integration_tests_sv2` (test "jd_integration") due to previous error
warning: build failed, waiting for other jobs to finish...

@jbesraa jbesraa force-pushed the 2025-01-21/template-provider-cleanup branch from be64cf7 to e3d5dbf Compare February 10, 2025 17:40
@jbesraa jbesraa force-pushed the 2025-01-21/template-provider-cleanup branch from e3d5dbf to 5ae7eb4 Compare February 11, 2025 07:18
@jbesraa
Copy link
Contributor Author

jbesraa commented Feb 11, 2025

Rebased without further changes

@jbesraa jbesraa force-pushed the 2025-01-21/template-provider-cleanup branch from 5ae7eb4 to 4083ced Compare February 12, 2025 08:40
@jbesraa jbesraa force-pushed the 2025-01-21/template-provider-cleanup branch from 4083ced to b43c553 Compare February 12, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests-integration::TemplateProvider cleanup
2 participants