chore: combine ci #1312
chore: combine ci #1312
Conversation
….yaml, fmt.yaml, clippy-lint.yaml, and add general-check.yaml to combine all in one file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1312 +/- ##
==========================================
- Coverage 19.29% 6.54% -12.75%
==========================================
Files 164 53 -111
Lines 10852 3268 -7584
==========================================
- Hits 2094 214 -1880
+ Misses 8758 3054 -5704
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Bencher Report| Branch | feature/Ci_combine |
| Testbed | sv2 |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result 1e3 x estimated cycles (Result Δ%) | Upper Boundary 1e3 x estimated cycles (Limit %) | Instructions | Benchmark Result instructions (Result Δ%) | Upper Boundary instructions (Limit %) | L1 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | L2 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | RAM Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot 🚷 view threshold | 2.13 (+1.05%) | 2.23 (95.50%) | 📈 view plot 🚷 view threshold | 473.00 (-0.09%) | 490.93 (96.35%) | 📈 view plot 🚷 view threshold | 733.00 (-0.40%) | 759.92 (96.46%) | 📈 view plot 🚷 view threshold | 7.00 (+40.88%) | 11.94 (58.65%) | 📈 view plot 🚷 view threshold | 39.00 (+1.11%) | 41.64 (93.65%) |
| client_sv2_handle_message_mining | 📈 view plot 🚷 view threshold | 8.31 (+1.12%) | 8.39 (99.09%) | 📈 view plot 🚷 view threshold | 2,137.00 (-0.00%) | 2,138.71 (99.92%) | 📈 view plot 🚷 view threshold | 3,154.00 (-0.16%) | 3,168.20 (99.55%) | 📈 view plot 🚷 view threshold | 38.00 (+6.83%) | 41.88 (90.74%) | 📈 view plot 🚷 view threshold | 142.00 (+1.74%) | 144.24 (98.45%) |
| client_sv2_mining_message_submit_standard | 📈 view plot 🚷 view threshold | 6.36 (+0.99%) | 6.45 (98.69%) | 📈 view plot 🚷 view threshold | 1,750.00 (-0.03%) | 1,767.83 (98.99%) | 📈 view plot 🚷 view threshold | 2,546.00 (-0.23%) | 2,576.21 (98.83%) | 📈 view plot 🚷 view threshold | 21.00 (+22.46%) | 24.61 (85.32%) | 📈 view plot 🚷 view threshold | 106.00 (+1.34%) | 108.67 (97.54%) |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot 🚷 view threshold | 14.83 (+0.72%) | 14.93 (99.31%) | 📈 view plot 🚷 view threshold | 4,694.00 (-0.01%) | 4,711.83 (99.62%) | 📈 view plot 🚷 view threshold | 6,743.00 (-0.20%) | 6,786.90 (99.35%) | 📈 view plot 🚷 view threshold | 56.00 (+24.06%) | 62.02 (90.30%) | 📈 view plot 🚷 view threshold | 223.00 (+0.83%) | 226.18 (98.59%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot 🚷 view threshold | 27.84 (+0.91%) | 28.03 (99.34%) | 📈 view plot 🚷 view threshold | 10,645.00 (+0.39%) | 10,692.04 (99.56%) | 📈 view plot 🚷 view threshold | 15,505.00 (+0.46%) | 15,582.27 (99.50%) | 📈 view plot 🚷 view threshold | 87.00 (+4.32%) | 98.71 (88.14%) | 📈 view plot 🚷 view threshold | 340.00 (+1.39%) | 342.67 (99.22%) |
| client_sv2_open_channel | 📈 view plot 🚷 view threshold | 4.46 (+1.35%) | 4.56 (97.61%) | 📈 view plot 🚷 view threshold | 1,461.00 (-0.03%) | 1,478.93 (98.79%) | 📈 view plot 🚷 view threshold | 2,155.00 (-0.26%) | 2,185.34 (98.61%) | 📈 view plot 🚷 view threshold | 12.00 (+47.98%) | 13.94 (86.10%) | 📈 view plot 🚷 view threshold | 64.00 (+2.07%) | 67.26 (95.16%) |
| client_sv2_open_channel_serialize | 📈 view plot 🚷 view threshold | 14.08 (+0.43%) | 14.20 (99.17%) | 📈 view plot 🚷 view threshold | 5,064.00 (-0.01%) | 5,081.93 (99.65%) | 📈 view plot 🚷 view threshold | 7,318.00 (-0.11%) | 7,353.08 (99.52%) | 📈 view plot 🚷 view threshold | 43.00 (+18.72%) | 47.91 (89.76%) | 📈 view plot 🚷 view threshold | 187.00 (+0.53%) | 190.89 (97.96%) |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot 🚷 view threshold | 22.91 (+0.96%) | 23.02 (99.52%) | 📈 view plot 🚷 view threshold | 8,040.00 (+0.11%) | 8,056.77 (99.79%) | 📈 view plot 🚷 view threshold | 11,690.00 (+0.05%) | 11,713.92 (99.80%) | 📈 view plot 🚷 view threshold | 81.00 (+7.35%) | 89.36 (90.65%) | 📈 view plot 🚷 view threshold | 309.00 (+1.73%) | 311.46 (99.21%) |
| client_sv2_setup_connection | 📈 view plot 🚷 view threshold | 4.71 (+0.48%) | 4.79 (98.37%) | 📈 view plot 🚷 view threshold | 1,502.00 (-0.03%) | 1,519.93 (98.82%) | 📈 view plot 🚷 view threshold | 2,276.00 (-0.11%) | 2,301.77 (98.88%) | 📈 view plot 🚷 view threshold | 11.00 (+17.04%) | 15.44 (71.26%) | 📈 view plot 🚷 view threshold | 68.00 (+0.72%) | 70.07 (97.04%) |
| client_sv2_setup_connection_serialize | 📈 view plot 🚷 view threshold | 16.27 (+0.72%) | 16.32 (99.69%) | 📈 view plot 🚷 view threshold | 5,963.00 (-0.01%) | 5,980.93 (99.70%) | 📈 view plot 🚷 view threshold | 8,648.00 (-0.19%) | 8,693.05 (99.48%) | 📈 view plot 🚷 view threshold | 54.00 (+34.66%) | 55.00 (98.18%) | 📈 view plot 🚷 view threshold | 210.00 (+0.87%) | 212.05 (99.03%) |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot 🚷 view threshold | 35.80 (+0.60%) | 35.93 (99.66%) | 📈 view plot 🚷 view threshold | 14,888.00 (+0.15%) | 14,916.05 (99.81%) | 📈 view plot 🚷 view threshold | 21,869.00 (+0.13%) | 21,914.93 (99.79%) | 📈 view plot 🚷 view threshold | 106.00 (+13.34%) | 117.74 (90.03%) | 📈 view plot 🚷 view threshold | 383.00 (+0.92%) | 385.40 (99.38%) |
|
| Branch | feature/Ci_combine |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result 1e3 x estimated cycles (Result Δ%) | Upper Boundary 1e3 x estimated cycles (Limit %) | Instructions | Benchmark Result 1e3 x instructions (Result Δ%) | Upper Boundary 1e3 x instructions (Limit %) | L1 Accesses | Benchmark Result 1e3 x accesses (Result Δ%) | Upper Boundary 1e3 x accesses (Limit %) | L2 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | RAM Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot 🚷 view threshold | 8.41 (-0.50%) | 8.67 (96.99%) | 📈 view plot 🚷 view threshold | 3.66 (-1.77%) | 3.86 (94.90%) | 📈 view plot 🚷 view threshold | 5.11 (-2.13%) | 5.44 (93.87%) | 📈 view plot 🚷 view threshold | 9.00 (+9.61%) | 15.68 (57.39%) | 📈 view plot 🚷 view threshold | 93.00 (+2.03%) | 96.22 (96.66%) |
| get_submit | 📈 view plot 🚷 view threshold | 95.36 (-0.00%) | 95.63 (99.72%) | 📈 view plot 🚷 view threshold | 59.26 (-0.25%) | 59.70 (99.26%) | 📈 view plot 🚷 view threshold | 85.07 (-0.30%) | 85.81 (99.14%) | 📈 view plot 🚷 view threshold | 48.00 (+8.23%) | 59.82 (80.24%) | 📈 view plot 🚷 view threshold | 287.00 (+2.36%) | 290.54 (98.78%) |
| get_subscribe | 📈 view plot 🚷 view threshold | 7.92 (-1.00%) | 8.23 (96.19%) | 📈 view plot 🚷 view threshold | 2.76 (-2.08%) | 2.94 (93.73%) | 📈 view plot 🚷 view threshold | 3.83 (-2.45%) | 4.14 (92.56%) | 📈 view plot 🚷 view threshold | 12.00 (-2.35%) | 20.38 (58.87%) | 📈 view plot 🚷 view threshold | 115.00 (+0.44%) | 117.79 (97.63%) |
| serialize_authorize | 📈 view plot 🚷 view threshold | 12.23 (-0.20%) | 12.50 (97.84%) | 📈 view plot 🚷 view threshold | 5.24 (-1.17%) | 5.42 (96.60%) | 📈 view plot 🚷 view threshold | 7.28 (-1.46%) | 7.60 (95.78%) | 📈 view plot 🚷 view threshold | 11.00 (+10.09%) | 18.52 (59.39%) | 📈 view plot 🚷 view threshold | 140.00 (+1.61%) | 142.46 (98.27%) |
| serialize_deserialize_authorize | 📈 view plot 🚷 view threshold | 24.67 (-0.17%) | 25.18 (97.97%) | 📈 view plot 🚷 view threshold | 9.79 (-0.77%) | 10.01 (97.77%) | 📈 view plot 🚷 view threshold | 13.79 (-0.94%) | 14.17 (97.28%) | 📈 view plot 🚷 view threshold | 35.00 (-2.23%) | 45.65 (76.66%) | 📈 view plot 🚷 view threshold | 306.00 (+0.88%) | 312.98 (97.77%) |
| serialize_deserialize_handle_authorize | 📈 view plot 🚷 view threshold | 30.29 (-0.13%) | 30.72 (98.58%) | 📈 view plot 🚷 view threshold | 11.99 (-0.54%) | 12.19 (98.39%) | 📈 view plot 🚷 view threshold | 16.95 (-0.67%) | 17.29 (98.03%) | 📈 view plot 🚷 view threshold | 56.00 (+0.53%) | 67.17 (83.38%) | 📈 view plot 🚷 view threshold | 373.00 (+0.57%) | 378.99 (98.42%) |
| serialize_deserialize_handle_submit | 📈 view plot 🚷 view threshold | 126.47 (+0.01%) | 126.78 (99.76%) | 📈 view plot 🚷 view threshold | 73.12 (-0.19%) | 73.53 (99.44%) | 📈 view plot 🚷 view threshold | 104.77 (-0.24%) | 105.50 (99.31%) | 📈 view plot 🚷 view threshold | 106.00 (-0.17%) | 125.42 (84.52%) | 📈 view plot 🚷 view threshold | 605.00 (+1.27%) | 608.59 (99.41%) |
| serialize_deserialize_handle_subscribe | 📈 view plot 🚷 view threshold | 27.91 (-0.03%) | 28.39 (98.28%) | 📈 view plot 🚷 view threshold | 9.58 (-0.60%) | 9.76 (98.13%) | 📈 view plot 🚷 view threshold | 13.52 (-0.78%) | 13.84 (97.68%) | 📈 view plot 🚷 view threshold | 71.00 (+10.22%) | 77.75 (91.32%) | 📈 view plot 🚷 view threshold | 401.00 (+0.47%) | 409.77 (97.86%) |
| serialize_deserialize_submit | 📈 view plot 🚷 view threshold | 115.23 (-0.00%) | 115.71 (99.59%) | 📈 view plot 🚷 view threshold | 67.89 (-0.25%) | 68.41 (99.24%) | 📈 view plot 🚷 view threshold | 97.36 (-0.31%) | 98.27 (99.07%) | 📈 view plot 🚷 view threshold | 68.00 (+5.16%) | 86.02 (79.05%) | 📈 view plot 🚷 view threshold | 501.00 (+1.65%) | 502.42 (99.72%) |
| serialize_deserialize_subscribe | 📈 view plot 🚷 view threshold | 23.27 (-0.22%) | 23.82 (97.69%) | 📈 view plot 🚷 view threshold | 8.13 (-0.74%) | 8.31 (97.76%) | 📈 view plot 🚷 view threshold | 11.42 (-0.91%) | 11.74 (97.28%) | 📈 view plot 🚷 view threshold | 39.00 (+0.85%) | 50.45 (77.30%) | 📈 view plot 🚷 view threshold | 333.00 (+0.45%) | 342.28 (97.29%) |
| serialize_submit | 📈 view plot 🚷 view threshold | 99.84 (+0.06%) | 100.10 (99.75%) | 📈 view plot 🚷 view threshold | 61.33 (-0.22%) | 61.73 (99.35%) | 📈 view plot 🚷 view threshold | 87.93 (-0.28%) | 88.64 (99.20%) | 📈 view plot 🚷 view threshold | 52.00 (+9.13%) | 66.15 (78.61%) | 📈 view plot 🚷 view threshold | 333.00 (+2.44%) | 335.96 (99.12%) |
| serialize_subscribe | 📈 view plot 🚷 view threshold | 11.44 (+0.33%) | 11.59 (98.64%) | 📈 view plot 🚷 view threshold | 4.11 (-1.31%) | 4.28 (95.99%) | 📈 view plot 🚷 view threshold | 5.69 (-1.68%) | 6.00 (94.91%) | 📈 view plot 🚷 view threshold | 15.00 (+10.41%) | 23.38 (64.16%) | 📈 view plot 🚷 view threshold | 162.00 (+2.30%) | 163.76 (98.92%) |
|
| Branch | feature/Ci_combine |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| client-submit-serialize | 📈 view plot 🚷 view threshold | 6,622.50 (+0.56%) | 6,934.12 (95.51%) |
| client-submit-serialize-deserialize | 📈 view plot 🚷 view threshold | 7,359.20 (-0.82%) | 7,864.79 (93.57%) |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 8,017.00 (-1.21%) | 9,414.13 (85.16%) |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 880.43 (+1.13%) | 946.75 (93.00%) |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | 📈 view plot 🚷 view threshold | 673.71 (-0.06%) | 720.34 (93.53%) |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | 📈 view plot 🚷 view threshold | 246.56 (-1.12%) | 265.66 (92.81%) |
| client-sv1-get-authorize/client-sv1-get-authorize | 📈 view plot 🚷 view threshold | 156.84 (-0.56%) | 167.05 (93.89%) |
| client-sv1-get-submit | 📈 view plot 🚷 view threshold | 6,372.50 (+0.25%) | 6,813.08 (93.53%) |
| client-sv1-get-subscribe/client-sv1-get-subscribe | 📈 view plot 🚷 view threshold | 282.08 (-0.56%) | 327.91 (86.02%) |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 747.37 (+2.36%) | 782.41 (95.52%) |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | 📈 view plot 🚷 view threshold | 594.47 (+0.48%) | 627.70 (94.71%) |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | 📈 view plot 🚷 view threshold | 204.32 (-1.13%) | 225.74 (90.51%) |
There was a problem hiding this comment.
Thanks for looking into this. i'am yet to give it a thorough review but can you please fix ci https://github.com/stratum-mining/stratum/actions/runs/12425379179/workflow ?
sure, i do it as a syntax test and forgot to fix |
|
you think that we can set some pattern to the jobs names? i made just a "draft" to bring to table |
There was a problem hiding this comment.
Is there anyway to make this shorter?
Can we try to avoid repeating this following part?
runs-on: ${{ matrix.os }}
strategy:
matrix:
os:
- macos-latest
- ubuntu-latest
include:
- os: macos-latest
target: x86_64-apple-darwin
- os: ubuntu-latest
target: x86_64-unknown-linux-musl
steps:
- uses: actions/checkout@v4
- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: 1.75.0
override: true
components: clippy
There was a problem hiding this comment.
This is going in the right direction but currently it does not seem to be fully working https://github.com/stratum-mining/stratum/actions/runs/12472789699/workflow
|
You can take some inspiration from here https://github.com/lightningdevkit/rust-lightning/tree/main/ci If you feel the need to move things to a shell script and just invoke it in the GH action. I think that would be also great for local dev env where devs can just call the shell script to replicate the GH action flow. Edit: Maybe this is a bit too much for this PR and can happen in a subsequent one. |
|
You think that is good? @jbesraa |
…ithub inside a workflows directory
Greats sugg's, i hope this help to make the code more clean, and easy to understand to others, and ourselfs too |
|
I think we should change |
|
I haven't really looked into the contents of the PR, but overall I feel the commit history is getting really dirty we are introducing changes and later adding new commits to fix things from previous commits if we merged this PR as it is, our commit history on I highly recommend to the PR author to study how to do rebase and squash on |
thanks for advise, i'll look into this! |
… lower case, and create bash script to ci job.
….yaml, fmt.yaml, clippy-lint.yaml, and add general-check.yaml to combine all in one file. chore: fix MSRV incorrect job syntax chore: update general-check to be more clean
…stribution_sv2`: remove the `no_std` feature and make them `#![no_std]` as they never use `std` anywhere. - bump their MAJOR version because of feature removal - bump the dependant crates PATCH version - updates docs chore: create shell script to make general-check.yaml more clean. chore: move shell scripts to /scripts chore: fix path to script on general-check.yaml chore: fix path to script on general-check.yaml
chore: update names to a pattern, and also organize bash scripts to github inside a workflows directory chore: adjust wrong clippy.sh file. chore: update general-check.yaml to rust-check.yaml, and job names to lower case, and create bash script to ci job. chore: remove comments, and add perm to test.sh
|
before foward with PR, can you guys leave a tip to improve the commits like the plebhash said, it just rebase and squash all my commits to only one? @Shourya742 @jbesraa |
There was a problem hiding this comment.
Note that by default we want each job to run on both stable and our-msrv versions unless we specify something different, like for cargo fmt we only use nightly. Moreover, some of the jobs have OS switch but not others, we should be consistent with this.
Yea I would squash it all into a single commit and add as much context as possible in the commit body while leaving the commit title under ~80 chars.
nice, before forward with pr, i will try to make it, i only have fear to break something and can't recover |
We are here to help, just post any problem you get stuck on |
…d create a new script with examples with new job ci-example.
….yaml, fmt.yaml, clippy-lint.yaml, and add general-check.yaml to combine all in one file. chore: fix MSRV incorrect job syntax chore: update general-check to be more clean
…stribution_sv2`: remove the `no_std` feature and make them `#![no_std]` as they never use `std` anywhere. - bump their MAJOR version because of feature removal - bump the dependant crates PATCH version - updates docs chore: create shell script to make general-check.yaml more clean. chore: move shell scripts to /scripts chore: fix path to script on general-check.yaml chore: fix path to script on general-check.yaml
chore: update names to a pattern, and also organize bash scripts to github inside a workflows directory chore: adjust wrong clippy.sh file. chore: update general-check.yaml to rust-check.yaml, and job names to lower case, and create bash script to ci job. chore: remove comments, and add perm to test.sh chore: remove test.yaml, rust-msrv.yaml, semver-check.yaml, lockfiles.yaml, fmt.yaml, clippy-lint.yaml, and add general-check.yaml to combine all in one file. chore: fix MSRV incorrect job syntax chore: update general-check to be more clean
chore: update names to a pattern, and also organize bash scripts to github inside a workflows directory chore: adjust wrong clippy.sh file. chore: update general-check.yaml to rust-check.yaml, and job names to lower case, and create bash script to ci job. chore: remove comments, and add perm to test.sh chore: add condition to check if directory exist chore: fix path to test.sh chore: try to fix path to test.sh
Hello, as required try to combine all asked yamls in only one yaml to ci/cd separated by jobs.
Issue: #1272