-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump crates versions for docs on release v1.1.0 #1222
Conversation
Bencher Report
Click to view all benchmark results
|
Bencher Report
Click to view all benchmark results
|
Bencher Report
Click to view all benchmark results
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1222 +/- ##
=======================================
Coverage 19.36% 19.36%
=======================================
Files 164 164
Lines 10811 10811
=======================================
Hits 2094 2094
Misses 8717 8717
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Semantic Versioning: |
we're not really fixing any bugs, and this is adding functionality in a backward compatible manner |
But we're not making any changes to the code or adding any new api. |
which functionality are you adding? @plebhash |
if that is the case we should increase pathc version |
when we first wrote Rust Docs for so I followed the same criteria here. I'm fine on using this new criteria (bump PATCH instead of MINOR) for the crates we document on the next iteration. But I don't think it would be a good idea to change this PR since those crates have now been published and that is irreversible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
close #1221