-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch roles_logic_sv2
with_serde
flag
#1101
Merged
plebhash
merged 1 commit into
stratum-mining:dev
from
plebhash:patch-roles-logic-sv2-serde-flag
Aug 13, 2024
Merged
patch roles_logic_sv2
with_serde
flag
#1101
plebhash
merged 1 commit into
stratum-mining:dev
from
plebhash:patch-roles-logic-sv2-serde-flag
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencher
🚨 8 ALERTS: Threshold Boundary Limits exceeded!
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
🚨 1 ALERT: Threshold Boundary Limit exceeded!
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
🚨 2 ALERTS: Threshold Boundary Limits exceeded!
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
GitGab19
approved these changes
Aug 13, 2024
plebhash
force-pushed
the
patch-roles-logic-sv2-serde-flag
branch
from
August 13, 2024 20:45
c95f6e0
to
56a9334
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this
framing_sv2/with_serde
flag was added toroles_logic_sv2
aiming to unblock the SemVer CI introduced via #985unfortunately the
with_serde
feature flag is broken forframing_sv2
, and that is having undesired consequences on downstream crates that useroles_logic_sv2
as dependenciesvia #1100 we can keep our SemVer CI unblocked by this problem, but we also need to make sure
roles_logic_sv2
does not includeframing_sv2/with_serde
this PR is patching
roles_logic_sv2
to achieve this goal