Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use richer Display for devicemapper Core errors #1179

Merged
merged 3 commits into from
Sep 19, 2018
Merged

Use richer Display for devicemapper Core errors #1179

merged 3 commits into from
Sep 19, 2018

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented Sep 13, 2018 •
edited
Loading

Addresses: #1160.

@mulkieran mulkieran self-assigned this Sep 13, 2018
@mulkieran
Copy link
Member Author

This is an alternative to #1166.

@mulkieran mulkieran changed the title Master destroy Use richer Display for devicemapper Core errors Sep 13, 2018
@mulkieran mulkieran mentioned this pull request Sep 13, 2018
Closed
@agrover
Copy link
Contributor

agrover commented Sep 13, 2018

#1166 also made BUSY a DbusErrorEnum::ERROR instead of INTERNAL_ERROR. This PR doesn't. I have opened #1181 and suggest it be resolved as part of this PR or a subsequent one.

@agrover
Copy link
Contributor

agrover commented Sep 17, 2018

@mulkieran hi, please review and consider #1194?

@mulkieran
Update to devicemapper-rs v0.26.0
2124860 
Signed-off-by: mulhern <[email protected]>
@mulkieran
Use display rather than description for DmError::Core errors
907570b 
Due to error_chain rules, the display is fuller and more interesting than
the description.

Signed-off-by: mulhern <[email protected]>
@mulkieran
Copy link
Member Author

@agrover I'ld rather deal with the Enum stuff separately. We once had a clear meaning for INTERNAL_ERROR which was "internal error". I think this inevitably rotted because of our type-based approach to generating D-Bus error codes. I don't mind throwing errors into other categories, but it is a separate issue.

@agrover
Copy link
Contributor

agrover commented Sep 18, 2018

Ok sounds good.

This was referenced Sep 18, 2018
Closed
Closed
Closed
@mergify mergify bot merged commit 4899990 into stratis-storage:master Sep 19, 2018
@mulkieran mulkieran deleted the master-destroy branch September 20, 2018 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasleson tasleson tasleson approved these changes

@agrover agrover agrover approved these changes

Assignees

@mulkieran mulkieran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mulkieran @agrover @tasleson