Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory: Drop support for managed memory #445

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

stotko
Copy link
Owner

@stotko stotko commented Nov 19, 2024

Managed memory has always been a niche feature in the memory module and required more complex initialization code including additional workarounds to ensure correct behavior on older GPUs. Other frameworks like PyTorch also do not support it for similar reasons. Thus, drop the support for managed memory. This will facilitate future improvements such as more complete stream/execution policy support.

@stotko stotko added this to the 2.0.0 milestone Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (9005240) to head (535dae5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
- Coverage   97.61%   97.53%   -0.09%     
==========================================
  Files          32       32              
  Lines        2602     2556      -46     
==========================================
- Hits         2540     2493      -47     
- Misses         62       63       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@stotko stotko merged commit b751532 into master Nov 19, 2024
60 of 61 checks passed
@stotko stotko deleted the drop_managed_memory branch November 19, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant