Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory: Simplify names of backend functions #442

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

stotko
Copy link
Owner

@stotko stotko commented Nov 18, 2024

The backend implementation of memory used the term "dispatch" to indicate that the backend is performing the operation based on the passed memory type. However, this just makes the names more complex. Furthermore, auxiliary functions for actually calling the backend implementation are defined as well which, however, are never exposed outside and just add another layer of indirection. Simplify the name and call convention to reduce bloat and prepare the backends for future feature additions.

@stotko stotko added this to the 2.0.0 milestone Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.45%. Comparing base (8a0abf1) to head (7daf62b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/stdgpu/openmp/impl/memory.cpp 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
+ Coverage   97.42%   97.45%   +0.02%     
==========================================
  Files          32       32              
  Lines        2603     2594       -9     
==========================================
- Hits         2536     2528       -8     
+ Misses         67       66       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stotko stotko merged commit d621e2b into master Nov 18, 2024
60 of 61 checks passed
@stotko stotko deleted the memory_backend_simplify branch November 18, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant