Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Bump required thrust version to 1.13.1 #429

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

stotko
Copy link
Owner

@stotko stotko commented Aug 19, 2024

Fixing a compilation issue with thrust on CUDA 12.6 required leveraging a macro that was introduced in thrust 1.13.1 (and CUDA 11.5), see #428. Although we technically support version down to CUDA 11.0 (released March 2020), such an old version will very likely not be used as support for the current GPU generations (RTX 30XX and 40XX) was not present at that time. Thus, bump to the requirements to thrust 1.13.1 and CUDA 11.5 (released October 2021). This may also unblock some further cleanups in the future.

@stotko stotko added this to the 2.0.0 milestone Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.38%. Comparing base (1d29bb6) to head (edbdae0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
+ Coverage   97.34%   97.38%   +0.03%     
==========================================
  Files          32       32              
  Lines        2524     2524              
==========================================
+ Hits         2457     2458       +1     
+ Misses         67       66       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stotko stotko merged commit d57a490 into master Aug 19, 2024
61 checks passed
@stotko stotko deleted the bump_cuda_thrust branch August 19, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant