Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #369

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
+8 −8
Open

Fix typos #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5353623
typos client.ts
Dimitrolito Dec 19, 2024
52f4d83
typos nftClient.ts
Dimitrolito Dec 19, 2024
3bcff27
typos nftClient.test.ts
Dimitrolito Dec 19, 2024
6cfbd8f
typos useNftClient.ts
Dimitrolito Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/core-sdk/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export class StoryClient {
}

/**
* Factory method for creating a SDK client with a signer.
* Factory method for creating an SDK client with a signer.
*
* @param config StoryClient - the configuration for a new SDK client
*/
Expand All @@ -82,7 +82,7 @@ export class StoryClient {
}

/**
* Factory method for creating a SDK client with a signer.
* Factory method for creating an SDK client with a signer.
*
* @param config WalletClientConfig - the configuration for a new SDK client
*/
Expand All @@ -95,7 +95,7 @@ export class StoryClient {
}

/**
* Factory method for creating a SDK client with a signer.
* Factory method for creating an SDK client with a signer.
*
* @param config UseAccountStoryConfig - the configuration for a new SDK client
*/
Expand Down
4 changes: 2 additions & 2 deletions packages/core-sdk/src/resources/nftClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export class NftClient {

/**
* Creates a new SPG NFT Collection.
* @param request - The request object containing necessary data to create a SPG NFT Collection.
* @param request - The request object containing necessary data to create an SPG NFT Collection.
* @param request.name - The name of the collection.
* @param request.symbol - The symbol of the collection.
* @param request.isPublicMinting - If true, anyone can mint from the collection. If false, only the addresses with the minter role can mint.
Expand Down Expand Up @@ -91,7 +91,7 @@ export class NftClient {
return { txHash: txHash };
}
} catch (error) {
handleError(error, "Failed to create a SPG NFT collection");
handleError(error, "Failed to create an SPG NFT collection");
}
}
}
4 changes: 2 additions & 2 deletions packages/core-sdk/test/unit/resources/nftClient.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe("Test NftClient", () => {
});
} catch (e) {
expect((e as Error).message).equal(
"Failed to create a SPG NFT collection: Invalid mint fee token address, mint fee is greater than 0.",
"Failed to create an SPG NFT collection: Invalid mint fee token address, mint fee is greater than 0.",
);
}
});
Expand All @@ -59,7 +59,7 @@ describe("Test NftClient", () => {
});
} catch (e) {
expect((e as Error).message).equal(
"Failed to create a SPG NFT collection: Invalid mint fee token address, mint fee is greater than 0.",
"Failed to create an SPG NFT collection: Invalid mint fee token address, mint fee is greater than 0.",
);
}
});
Expand Down
2 changes: 1 addition & 1 deletion packages/react-sdk/src/resources/useNftClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const useNftClient = () => {

/**
* Creates a new SPG NFT Collection.
* @param request - The request object containing necessary data to create a SPG NFT Collection.
* @param request - The request object containing necessary data to create an SPG NFT Collection.
* @param request.name - The name of the collection.
* @param request.symbol - The symbol of the collection.
* @param request.maxSupply - The maximum supply of the collection.
Expand Down
Loading