remove attach license terms check from mintLicenseTokens #367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the following code from
mintLicenseTokens
:The reason for this change is because, as the mintLicenseTokens function is described, it should be able to mint private license tokens: "IP owners can mint license tokens for their IPs for arbitrary license terms without attaching the license terms to IP."
The function is currently throwing an error if the terms are not attached, but an IP owner should call this function and be able to mint license tokens even if the terms aren't attached.
I wanted to add a check to see if the IP owner == the sender of the call, but I couldn't find an SDK function to do this, and other functions like
attachLicenseTerms
don't make this check either.