SDK Workflows Update #361
Merged
SDK Workflows Update #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Internal and External PRs should only call `unit` test cases. - Integration test cases should only trigger when a PR is merged on `dev` - Removed all the .env variables that were not being used. - Removed all the references to `sepolia` and changed when necessary to `odyssey` - Removed Anvil
…ws-test Origin/dev polania/workflows test
…ws-test Update test_file.txt
…oryprotocol/sdk into origin/dev-bpolania/workflows
bpolania
requested review from
LeoHChen,
DonFungible,
edisonz0718,
jacob-tucker,
AndyBoWu and
allenchuang
as code owners
bpolania
temporarily deployed
to
beta-sepolia
GitHub Actions
Inactive
bonnie57
reviewed
Dec 11, 2024
package.json
Outdated
| @@ -10,6 +10,7 @@ | |||
| "lint": "turbo run lint", | |||
| "fix": "turbo run fix", | |||
| "test": "turbo run test --no-cache --concurrency=1", | |||
| "test:integration": "turbo run test:integration --no-cache --concurrency=1", | |||
There was a problem hiding this comment.
why do you limit the concurrency of 1? If you don't have a limit, you can run fast.
bpolania
temporarily deployed
to
beta-sepolia
GitHub Actions
Inactive
bpolania
temporarily deployed
to
beta-sepolia
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This github workflow upgrade updates the
pr-internalworkflow so it runs integration tests only when merging todev.pull_requestorpush, it will run either unit test or integration tests reusable workflows.timestamprequirement forpushevents.Test Plan
To test this completely it's necessary to make a PR and merge it.