Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement multicall #314

Merged
merged 16 commits into from
Nov 13, 2024
Merged

Implement multicall #314

merged 16 commits into from
Nov 13, 2024

Conversation

bonnie57
Copy link
Collaborator

@bonnie57 bonnie57 commented Nov 8, 2024 •
edited
Loading

Description

Methods included:

  • batchRegister
  • BatchregisterDerivative
  • batchRegisterWithIpMetadata
  • BatchMintAndRegisterIpAssetWithPilTerms
  • BatchmintAndRegisterIpAndMakeDerivative

Also export getSignature method, refactor how to calculate the deadline, and bump the version to 1.2.0-rc.2.

Test Plan

image image

@bonnie57 bonnie57 changed the title [WIP] Implement multicall Implement multicall Nov 12, 2024
DonFungible
DonFungible reviewed Nov 12, 2024
View reviewed changes
packages/core-sdk/src/types/resources/ipAsset.ts Outdated Show resolved Hide resolved
packages/core-sdk/src/types/resources/ipAsset.ts Outdated Show resolved Hide resolved
packages/core-sdk/src/types/resources/ipAsset.ts Outdated Show resolved Hide resolved
packages/core-sdk/src/types/resources/ipAsset.ts Outdated Show resolved Hide resolved
DonFungible
DonFungible approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@DonFungible DonFungible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bonnie57 bonnie57 requested a review from LeoHChen as a code owner November 13, 2024 06:42
@bonnie57 bonnie57 merged commit 456fc3d into dev Nov 13, 2024
6 checks passed
@bonnie57 bonnie57 deleted the bonnie/SDK-23 branch November 13, 2024 06:50
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 13, 2024
@bonnie57
Implement multicall (storyprotocol#314)
fcd579f 
* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 13, 2024
@bonnie57
Implement multicall (storyprotocol#314)
f00ee5f 
* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 13, 2024
@bonnie57
Implement multicall (storyprotocol#314)
489f724 
* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 13, 2024
@bonnie57
Implement multicall (storyprotocol#314)
2c937d0 
* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 13, 2024
@bonnie57
Implement multicall (storyprotocol#314)
f135ce7 
* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 13, 2024
@bonnie57
Implement multicall (storyprotocol#314)
3272bb6 
* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2
DonFungible added a commit that referenced this pull request Nov 13, 2024
@bonnie57 @DonFungible @AndyBoWu
Bump up sdk version to 1.2.0-rc.2 (#317)
b5a3b5c 
* Feat/make isRegistered public (#311)

* make isRegistered public

* make isRegistered public

* [feat] add codeowners for pr review (#316)

* Implement multicall  (#314)

* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2

---------

Co-authored-by: Don <[email protected]>
Co-authored-by: Andy Wu <[email protected]>
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 14, 2024
@bonnie57
Implement multicall (storyprotocol#314)
be0c15d 
* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 14, 2024
@bonnie57
Implement multicall (storyprotocol#314)
7138bde 
* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 14, 2024
@bonnie57
Implement multicall (storyprotocol#314)
33d4df0 
* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 14, 2024
@bonnie57
Implement multicall (storyprotocol#314)
8ce91ee 
* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 14, 2024
@bonnie57
Implement multicall (storyprotocol#314)
1ff5ef6 
* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 14, 2024
@bonnie57
Implement multicall (storyprotocol#314)
e1a48f7 
* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 14, 2024
@bonnie57 @DonFungible @AndyBoWu
Dev (#148)
e174d27 
* Feat/make isRegistered public (storyprotocol#311)

* make isRegistered public

* make isRegistered public

* [feat] add codeowners for pr review (storyprotocol#316)

* Implement multicall  (storyprotocol#314)

* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2

* fix:Update

---------

Co-authored-by: Don <[email protected]>
Co-authored-by: Andy Wu <[email protected]>
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 14, 2024
@bonnie57
Implement multicall (storyprotocol#314)
28a7d9f 
* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 14, 2024
@bonnie57 @DonFungible @AndyBoWu
Revert "Dev" (#149)
a1dc37c 
* Dev (#148)

* Feat/make isRegistered public (storyprotocol#311)

* make isRegistered public

* make isRegistered public

* [feat] add codeowners for pr review (storyprotocol#316)

* Implement multicall  (storyprotocol#314)

* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2

* fix:Update

---------

Co-authored-by: Don <[email protected]>
Co-authored-by: Andy Wu <[email protected]>

* Revert "Dev (#148)"

This reverts commit e174d27.

---------

Co-authored-by: Don <[email protected]>
Co-authored-by: Andy Wu <[email protected]>
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 14, 2024
@bonnie57 @DonFungible @AndyBoWu
Dev (#150)
fa58120 
* Feat/make isRegistered public (storyprotocol#311)

* make isRegistered public

* make isRegistered public

* [feat] add codeowners for pr review (storyprotocol#316)

* Implement multicall  (storyprotocol#314)

* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2

* fix:Update

---------

Co-authored-by: Don <[email protected]>
Co-authored-by: Andy Wu <[email protected]>
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 14, 2024
@bonnie57
Implement multicall (storyprotocol#314)
aca1248 
* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 14, 2024
@bonnie57 @DonFungible @AndyBoWu
Dev (#151)
93b7401 
* Feat/make isRegistered public (storyprotocol#311)

* make isRegistered public

* make isRegistered public

* [feat] add codeowners for pr review (storyprotocol#316)

* Implement multicall  (storyprotocol#314)

* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2

* fix:Update

* feat(lang): add Polish language

---------

Co-authored-by: Don <[email protected]>
Co-authored-by: Andy Wu <[email protected]>
bonnie57 added a commit to bonnie57/sdk that referenced this pull request Nov 14, 2024
@bonnie57
Implement multicall (storyprotocol#314)
e2f6725 
* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2
bonnie57 added a commit that referenced this pull request Dec 3, 2024
@bonnie57 @DonFungible @AndyBoWu
Bump up sdk version to 1.2.0-rc.2 (#317)
4caea31 
* Feat/make isRegistered public (#311)

* make isRegistered public

* make isRegistered public

* [feat] add codeowners for pr review (#316)

* Implement multicall  (#314)

* Add batchMintAndRegisterIpAssetWithPilTerms method

* Add batchRegisterDerivative method

* Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation

* Add batchMintAndRegisterIpAndMakeDerivative method

* Add batch register method

* Fix issue about Invalid signature

* Refactor code

* Add unit tests

* Fix unit test

* Export getSignature method

* Add batchRegisterWithIpMetadata method

* Enhance code

* Refactor multicall about protocol core

* Remove integration test in command

* Refactor getDeadline method

* Bump up sdk to 1.2.0-rc.2

---------

Co-authored-by: Don <[email protected]>
Co-authored-by: Andy Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonFungible DonFungible DonFungible approved these changes

@edisonz0718 edisonz0718 Awaiting requested review from edisonz0718 edisonz0718 is a code owner

@jacob-tucker jacob-tucker Awaiting requested review from jacob-tucker jacob-tucker is a code owner

@AndyBoWu AndyBoWu Awaiting requested review from AndyBoWu AndyBoWu is a code owner

@LeoHChen LeoHChen Awaiting requested review from LeoHChen LeoHChen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonnie57 @DonFungible