Feat/make isRegistered public #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonFungible
requested review from
edisonz0718,
jacob-tucker and
AndyBoWu
as code owners
DonFungible
temporarily deployed
to
beta-sepolia
GitHub Actions
Inactive
bonnie57
approved these changes
Nov 4, 2024
bonnie57
pushed a commit
to bonnie57/sdk
that referenced
this pull request
Nov 13, 2024
* make isRegistered public * make isRegistered public
bonnie57
pushed a commit
to bonnie57/sdk
that referenced
this pull request
Nov 13, 2024
* make isRegistered public * make isRegistered public
bonnie57
pushed a commit
to bonnie57/sdk
that referenced
this pull request
Nov 13, 2024
* make isRegistered public * make isRegistered public
bonnie57
pushed a commit
to bonnie57/sdk
that referenced
this pull request
Nov 13, 2024
* make isRegistered public * make isRegistered public
bonnie57
pushed a commit
to bonnie57/sdk
that referenced
this pull request
Nov 13, 2024
* make isRegistered public * make isRegistered public
bonnie57
pushed a commit
to bonnie57/sdk
that referenced
this pull request
Nov 13, 2024
* make isRegistered public * make isRegistered public
DonFungible
added a commit
that referenced
this pull request
Nov 13, 2024
* Feat/make isRegistered public (#311) * make isRegistered public * make isRegistered public * [feat] add codeowners for pr review (#316) * Implement multicall (#314) * Add batchMintAndRegisterIpAssetWithPilTerms method * Add batchRegisterDerivative method * Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation * Add batchMintAndRegisterIpAndMakeDerivative method * Add batch register method * Fix issue about Invalid signature * Refactor code * Add unit tests * Fix unit test * Export getSignature method * Add batchRegisterWithIpMetadata method * Enhance code * Refactor multicall about protocol core * Remove integration test in command * Refactor getDeadline method * Bump up sdk to 1.2.0-rc.2 --------- Co-authored-by: Don <[email protected]> Co-authored-by: Andy Wu <[email protected]>
bonnie57
pushed a commit
to bonnie57/sdk
that referenced
this pull request
Nov 14, 2024
* make isRegistered public * make isRegistered public
bonnie57
pushed a commit
to bonnie57/sdk
that referenced
this pull request
Nov 14, 2024
* make isRegistered public * make isRegistered public
bonnie57
pushed a commit
to bonnie57/sdk
that referenced
this pull request
Nov 14, 2024
* make isRegistered public * make isRegistered public
bonnie57
pushed a commit
to bonnie57/sdk
that referenced
this pull request
Nov 14, 2024
* make isRegistered public * make isRegistered public
bonnie57
pushed a commit
to bonnie57/sdk
that referenced
this pull request
Nov 14, 2024
* make isRegistered public * make isRegistered public
bonnie57
pushed a commit
to bonnie57/sdk
that referenced
this pull request
Nov 14, 2024
* make isRegistered public * make isRegistered public
bonnie57
added a commit
to bonnie57/sdk
that referenced
this pull request
Nov 14, 2024
* Feat/make isRegistered public (storyprotocol#311) * make isRegistered public * make isRegistered public * [feat] add codeowners for pr review (storyprotocol#316) * Implement multicall (storyprotocol#314) * Add batchMintAndRegisterIpAssetWithPilTerms method * Add batchRegisterDerivative method * Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation * Add batchMintAndRegisterIpAndMakeDerivative method * Add batch register method * Fix issue about Invalid signature * Refactor code * Add unit tests * Fix unit test * Export getSignature method * Add batchRegisterWithIpMetadata method * Enhance code * Refactor multicall about protocol core * Remove integration test in command * Refactor getDeadline method * Bump up sdk to 1.2.0-rc.2 * fix:Update --------- Co-authored-by: Don <[email protected]> Co-authored-by: Andy Wu <[email protected]>
bonnie57
pushed a commit
to bonnie57/sdk
that referenced
this pull request
Nov 14, 2024
* make isRegistered public * make isRegistered public
bonnie57
added a commit
to bonnie57/sdk
that referenced
this pull request
Nov 14, 2024
* Dev (#148) * Feat/make isRegistered public (storyprotocol#311) * make isRegistered public * make isRegistered public * [feat] add codeowners for pr review (storyprotocol#316) * Implement multicall (storyprotocol#314) * Add batchMintAndRegisterIpAssetWithPilTerms method * Add batchRegisterDerivative method * Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation * Add batchMintAndRegisterIpAndMakeDerivative method * Add batch register method * Fix issue about Invalid signature * Refactor code * Add unit tests * Fix unit test * Export getSignature method * Add batchRegisterWithIpMetadata method * Enhance code * Refactor multicall about protocol core * Remove integration test in command * Refactor getDeadline method * Bump up sdk to 1.2.0-rc.2 * fix:Update --------- Co-authored-by: Don <[email protected]> Co-authored-by: Andy Wu <[email protected]> * Revert "Dev (#148)" This reverts commit e174d27. --------- Co-authored-by: Don <[email protected]> Co-authored-by: Andy Wu <[email protected]>
bonnie57
added a commit
to bonnie57/sdk
that referenced
this pull request
Nov 14, 2024
* Feat/make isRegistered public (storyprotocol#311) * make isRegistered public * make isRegistered public * [feat] add codeowners for pr review (storyprotocol#316) * Implement multicall (storyprotocol#314) * Add batchMintAndRegisterIpAssetWithPilTerms method * Add batchRegisterDerivative method * Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation * Add batchMintAndRegisterIpAndMakeDerivative method * Add batch register method * Fix issue about Invalid signature * Refactor code * Add unit tests * Fix unit test * Export getSignature method * Add batchRegisterWithIpMetadata method * Enhance code * Refactor multicall about protocol core * Remove integration test in command * Refactor getDeadline method * Bump up sdk to 1.2.0-rc.2 * fix:Update --------- Co-authored-by: Don <[email protected]> Co-authored-by: Andy Wu <[email protected]>
bonnie57
pushed a commit
to bonnie57/sdk
that referenced
this pull request
Nov 14, 2024
* make isRegistered public * make isRegistered public
bonnie57
added a commit
to bonnie57/sdk
that referenced
this pull request
Nov 14, 2024
* Feat/make isRegistered public (storyprotocol#311) * make isRegistered public * make isRegistered public * [feat] add codeowners for pr review (storyprotocol#316) * Implement multicall (storyprotocol#314) * Add batchMintAndRegisterIpAssetWithPilTerms method * Add batchRegisterDerivative method * Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation * Add batchMintAndRegisterIpAndMakeDerivative method * Add batch register method * Fix issue about Invalid signature * Refactor code * Add unit tests * Fix unit test * Export getSignature method * Add batchRegisterWithIpMetadata method * Enhance code * Refactor multicall about protocol core * Remove integration test in command * Refactor getDeadline method * Bump up sdk to 1.2.0-rc.2 * fix:Update * feat(lang): add Polish language --------- Co-authored-by: Don <[email protected]> Co-authored-by: Andy Wu <[email protected]>
bonnie57
added a commit
that referenced
this pull request
Dec 3, 2024
* Feat/make isRegistered public (#311) * make isRegistered public * make isRegistered public * [feat] add codeowners for pr review (#316) * Implement multicall (#314) * Add batchMintAndRegisterIpAssetWithPilTerms method * Add batchRegisterDerivative method * Enhance batchMintAndRegisterIpAssetWithPilTerms including unit tests and annotation * Add batchMintAndRegisterIpAndMakeDerivative method * Add batch register method * Fix issue about Invalid signature * Refactor code * Add unit tests * Fix unit test * Export getSignature method * Add batchRegisterWithIpMetadata method * Enhance code * Refactor multicall about protocol core * Remove integration test in command * Refactor getDeadline method * Bump up sdk to 1.2.0-rc.2 --------- Co-authored-by: Don <[email protected]> Co-authored-by: Andy Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
ipAsset.isRegistereda public function. Previously, it was private.