Refactor state management with custom hooks for loading and error states #222
Conversation
- Use useMemo to ensure the client is only created when the config changes.
0oooooooo0
requested review from
DonFungible,
edisonz0718,
jacob-tucker and
AndyBoWu
as code owners
…ient" This reverts commit 0fe6c5c.
WalkthroughThe changes introduce custom React hooks, Changes
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (9)
- packages/react-sdk/src/hooks/useError.ts (1 hunks)
- packages/react-sdk/src/hooks/useLoading.ts (1 hunks)
- packages/react-sdk/src/resources/useDispute.ts (4 hunks)
- packages/react-sdk/src/resources/useIpAccount.ts (4 hunks)
- packages/react-sdk/src/resources/useIpAsset.ts (7 hunks)
- packages/react-sdk/src/resources/useLicense.ts (7 hunks)
- packages/react-sdk/src/resources/useNftClient.ts (2 hunks)
- packages/react-sdk/src/resources/usePermission.ts (6 hunks)
- packages/react-sdk/src/resources/useRoyalty.ts (7 hunks)
Additional comments not posted (51)
packages/react-sdk/src/hooks/useError.ts (3)
3-3: Type definition looks good!The
ErrorStatetype definition is correct and provides the necessary structure for error states.
5-13: Hook implementation looks good!The
useErrorshook correctly initializes the error state and provides a method to update it. UsinguseCallbackforsetErroris a good practice.
18-18: Export statement looks good!The export statement correctly exports the
ErrorStatetype and theuseErrorshook.packages/react-sdk/src/hooks/useLoading.ts (3)
3-3: Type definition looks good!The
LoadingStatetype definition is correct and provides the necessary structure for loading states.
5-13: Hook implementation looks good!The
useLoadinghook correctly initializes the loading state and provides a method to update it. UsinguseCallbackforsetLoadingis a good practice.
18-18: Export statement looks good!The export statement correctly exports the
LoadingStatetype and theuseLoadinghook.packages/react-sdk/src/resources/useNftClient.ts (4)
8-9: Import statements look good!The import statements for
useLoadinganduseErrorsare correct and necessary for using the new hooks.
13-16: Initialization of loading states looks good!The initialization of loading states using the
useLoadinghook is correct and follows the new approach.
16-16: Initialization of error states looks good!The initialization of error states using the
useErrorshook is correct and follows the new approach.
37-45: Usage of the new hooks looks good!The usage of the new hooks
useLoadinganduseErrorsin thecreateNFTCollectionfunction is correct and simplifies the state management.packages/react-sdk/src/resources/useIpAccount.ts (6)
11-12: Import statements look good!The import statements for
useLoadinganduseErrorsare correct and necessary for using the new hooks.
16-21: Initialization of loading states looks good!The initialization of loading states using the
useLoadinghook is correct and follows the new approach.
21-21: Initialization of error states looks good!The initialization of error states using the
useErrorshook is correct and follows the new approach.
40-48: Usage of the new hooks inexecutefunction looks good!The usage of the new hooks
useLoadinganduseErrorsin theexecutefunction is correct and simplifies the state management.
68-76: Usage of the new hooks inexecuteWithSigfunction looks good!The usage of the new hooks
useLoadinganduseErrorsin theexecuteWithSigfunction is correct and simplifies the state management.
89-97: Usage of the new hooks ingetIpAccountNoncefunction looks good!The usage of the new hooks
useLoadinganduseErrorsin thegetIpAccountNoncefunction is correct and simplifies the state management.packages/react-sdk/src/resources/useDispute.ts (5)
17-22: Initialization of loading states looks good.The use of
useLoadinghook to manage loading states for specific dispute actions is a good approach.
22-24: Initialization of error states looks good.The use of
useErrorshook to manage error states for specific dispute actions is a good approach.
48-56: Handling loading and error states looks good.The
raiseDisputefunction correctly sets loading and error states using the custom hooks.
77-85: Handling loading and error states looks good.The
cancelDisputefunction correctly sets loading and error states using the custom hooks.
104-112: Handling loading and error states looks good.The
resolveDisputefunction correctly sets loading and error states using the custom hooks.packages/react-sdk/src/resources/useRoyalty.ts (8)
22-30: Initialization of loading states looks good.The use of
useLoadinghook to manage loading states for specific royalty-related actions is a good approach.
30-32: Initialization of error states looks good.The use of
useErrorshook to manage error states for specific royalty-related actions is a good approach.
52-60: Handling loading and error states looks good.The
collectRoyaltyTokensfunction correctly sets loading and error states using the custom hooks.
79-87: Handling loading and error states looks good.The
payRoyaltyOnBehalffunction correctly sets loading and error states using the custom hooks.
106-114: Handling loading and error states looks good.The
claimableRevenuefunction correctly sets loading and error states using the custom hooks.
134-142: Handling loading and error states looks good.The
claimRevenuefunction correctly sets loading and error states using the custom hooks.
159-167: Handling loading and error states looks good.The
snapshotfunction correctly sets loading and error states using the custom hooks.
181-191: Handling loading and error states looks good.The
getRoyaltyVaultAddressfunction correctly sets loading and error states using the custom hooks.packages/react-sdk/src/resources/useLicense.ts (8)
21-29: Initialization of loading states looks good.The use of
useLoadinghook to manage loading states for specific license-related actions is a good approach.
29-31: Initialization of error states looks good.The use of
useErrorshook to manage error states for specific license-related actions is a good approach.
49-59: Handling loading and error states looks good.The
registerNonComSocialRemixingPILfunction correctly sets loading and error states using the custom hooks.
77-85: Handling loading and error states looks good.The
registerCommercialUsePILfunction correctly sets loading and error states using the custom hooks.
104-112: Handling loading and error states looks good.The
registerCommercialRemixPILfunction correctly sets loading and error states using the custom hooks.
130-138: Handling loading and error states looks good.The
attachLicenseTermsfunction correctly sets loading and error states using the custom hooks.
169-177: Handling loading and error states looks good.The
mintLicenseTokensfunction correctly sets loading and error states using the custom hooks.
191-201: Handling loading and error states looks good.The
getLicenseTermsfunction correctly sets loading and error states using the custom hooks.packages/react-sdk/src/resources/usePermission.ts (7)
17-24: Initialization of loading states looks good.The use of
useLoadinghook to manage loading states for specific permission-related actions is a good approach.
24-26: Initialization of error states looks good.The use of
useErrorshook to manage error states for specific permission-related actions is a good approach.
56-64: Handling loading and error states looks good.The
setPermissionfunction correctly sets loading and error states using the custom hooks.
86-96: Handling loading and error states looks good.The
createSetPermissionSignaturefunction correctly sets loading and error states using the custom hooks.
115-123: Handling loading and error states looks good.The
setAllPermissionsfunction correctly sets loading and error states using the custom hooks.
146-154: Handling loading and error states looks good.The
setBatchPermissionsfunction correctly sets loading and error states using the custom hooks.
177-187: Handling loading and error states looks good.The
createBatchPermissionSignaturefunction correctly sets loading and error states using the custom hooks.packages/react-sdk/src/resources/useIpAsset.ts (7)
18-19: Imports look good.The new hooks
useLoadinganduseErrorsare correctly imported.
58-66: Changes inregisterfunction look good.The loading and error states are managed correctly using the new hooks.
88-96: Changes inregisterDerivativefunction look good.The loading and error states are managed correctly using the new hooks.
116-126: Changes inregisterDerivativeWithLicenseTokensfunction look good.The loading and error states are managed correctly using the new hooks.
153-163: Changes inmintAndRegisterIpAssetWithPilTermsfunction look good.The loading and error states are managed correctly using the new hooks.
190-200: Changes inregisterIpAndAttachPilTermsfunction look good.The loading and error states are managed correctly using the new hooks.
227-235: Changes inregisterDerivativeIpfunction look good.The loading and error states are managed correctly using the new hooks.
Overview
This PR refactors the state management for loading and error states by introducing custom hooks. The new approach uses generic types to dynamically handle different state keys, improving code maintainability and reducing repetition.
Changes
useLoadinghook to manage loading states.useErrorshook to manage error states.Benefits
How to Test
Additional Notes
Summary by CodeRabbit
Refactor
useLoadinganduseErrorsto manage loading states and errors across various functions, replacing the previoususeStateapproach.Bug Fixes
useDispute,useIpAccount,useIpAsset,useLicense,useNftClient,usePermission, anduseRoyaltyfunctions.These updates streamline state handling and enhance the user experience by providing more reliable and maintainable state management for various operations.