Update react-sdk version #216
Conversation
* [test] create release * [test] create release - 2
[fix] add condition check back
1.0.0-rc.9
Update publish CI + Bump version (#168)
Fix CI syntax issue
1.0.0-rc11
* Create test-slack-notifs.yml * Update test-slack-notifs.yml
* Update test-slack-notifs.yml * Update test-slack-notifs.yml
1.0.0-rc12
* Update publish-package.yaml * Update publish-package.yaml * Update publish-package.yaml * reusable slack workflow implemented
Publish rc15
bonnie57
requested review from
DonFungible,
edisonz0718,
jacob-tucker and
AndyBoWu
as code owners
WalkthroughThe recent changes focus on enhancing GitHub Actions workflows for distinct handling and publishing of core and react SDKs. New features include differentiated version outputs, updated workflows for dependency and release management, increased test timeouts, progress tracking, and specific test case modifications. These updates streamline the publishing process and improve development efficiency across multiple SDK packages. Changes
Sequence Diagram(s)sequenceDiagram
actor Developer
participant GitHubActions
participant NPM
Developer ->> GitHubActions: Push new changes to main
GitHubActions ->> GitHubActions: Run publish-react-sdk-package.yaml
GitHubActions ->> GitHubActions: Determine version to be published
GitHubActions ->> NPM: Fetch latest version from NPM
GitHubActions ->> GitHubActions: Compare latest and to-be-published versions
alt Versions differ
GitHubActions ->> GitHubActions: Build, Test, and Publish
GitHubActions ->> GitHubActions: Create new release
GitHubActions ->> Slack: Send notification
else Versions same
GitHubActions ->> Developer: Fail workflow with error
end
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/publish-package.yaml (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/publish-package.yaml
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/publish-package.yaml (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/publish-package.yaml
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .github/workflows/publish-package.yaml (3 hunks)
- packages/react-sdk/jest.config.js (1 hunks)
- packages/react-sdk/package.json (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- .github/workflows/publish-package.yaml
- packages/react-sdk/jest.config.js
- packages/react-sdk/package.json
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (2)
- package.json (1 hunks)
- packages/react-sdk/package.json (2 hunks)
Files skipped from review due to trivial changes (1)
- package.json
Files skipped from review as they are similar to previous changes (1)
- packages/react-sdk/package.json
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (2)
- packages/react-sdk/generator/index.js (3 hunks)
- packages/react-sdk/package.json (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/react-sdk/package.json
Additional comments not posted (4)
packages/react-sdk/generator/index.js (4)
5-6: LGTM! Imports are correct and necessary.The
cli-progressandexecmodules are correctly imported for the new functionality.
12-13: LGTM! Progress bar initialization is correct.The progress bar instance is correctly initialized with appropriate presets.
77-80: LGTM! Progress bar usage within the loop is correct.The progress bar is correctly initialized, started, and updated within the loop.
131-146: LGTM! Command execution and error handling are correct.The
execfunction is correctly used to run thenpm run fixcommand, and the error handling logic is appropriate. The progress bar is updated and stopped correctly.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (4)
- packages/core-sdk/test/integration/ipAsset.test.ts (3 hunks)
- packages/core-sdk/test/integration/license.test.ts (1 hunks)
- packages/react-sdk/test/integration/useIpAsset.test.ts (3 hunks)
- packages/wagmi-generator/package.json (1 hunks)
Files skipped from review due to trivial changes (3)
- packages/core-sdk/test/integration/ipAsset.test.ts
- packages/core-sdk/test/integration/license.test.ts
- packages/react-sdk/test/integration/useIpAsset.test.ts
Additional comments not posted (2)
packages/wagmi-generator/package.json (2)
8-8: Addition of@types/nodetodevDependenciesis appropriate.This addition provides type definitions for Node.js, which is beneficial for TypeScript projects.
16-16: Verify the necessity of movingwagmitodependencies.Ensure that
wagmiis required at runtime and not just during development. If it is only needed for development purposes, it should remain indevDependencies.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/publish-package.yaml (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/publish-package.yaml
| # version_to_publish: ${{ needs.print_version_to_publish.outputs.react_sdk_version_to_be_published }} | ||
|
|
||
| send_slack_notif-react-sdk: | ||
| needs: [build-test-publish, print_version_to_publish] |
There was a problem hiding this comment.
Why doesn't this need to check create-release-react-sdk step
Update react-sdk version (#216)
Description
publish-package.yamlto publishreact-sdknpm run generatecommandSummary by CodeRabbit