Update publish-package.yml #193
Conversation
cenevan
requested review from
DonFungible,
edisonz0718,
jacob-tucker and
AndyBoWu
as code owners
WalkthroughA new step named Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant Developer
participant GitHub Actions
participant NPM Registry
participant Slack
Developer->>GitHub Actions: Push changes
GitHub Actions->>NPM Registry: Publish package
GitHub Actions->>Slack: Send Slack notification
Slack->>Team Members: Notify about package published
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/publish-package.yaml (1 hunks)
Additional comments not posted (1)
.github/workflows/publish-package.yaml (1)
130-140: Ensure the new Slack notification step is correctly integrated.The new
send_slack_notifjob is well-integrated with the existing workflow, correctly depending on bothbuild-test-publishandcreate_releasejobs. The usage of secrets and parameters in thewithblock appears correct. However, verify the image URL and ensure the Slack bot token has the necessary permissions.Verification successful
The new
send_slack_notifjob is well-integrated with the existing workflow, correctly depending on bothbuild-test-publishandcreate_releasejobs. The usage of secrets and parameters in thewithblock appears correct. The image URL is valid and accessible, and the secrets are correctly referenced in the workflow file.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the image URL is accessible and valid. # Test: Check if the image URL returns a successful HTTP status code. curl -o /dev/null --silent --head --write-out '%{http_code}' https://imgur.com/a/6P1xFvELength of output: 94
Script:
#!/bin/bash # Description: Verify the usage of secrets in the workflow file. # Test: Check if the secrets are correctly referenced in the workflow file. grep -E 'secrets\.(SLACK_CHANNEL_ID_STORY_57BLOCKS|SLACK_BOT_TOKEN)' .github/workflows/publish-package.yamlLength of output: 230
* Update publish-package.yaml * Update publish-package.yaml * Update publish-package.yaml * reusable slack workflow implemented
* [feat] refactor the package publication workflow (#152) * [test] create release (#153) * [feature] remove legacy workflow to create gh release (#157) * Test/create release workflow (#155) * [test] create release * [test] create release - 2 * Update publish-package.yaml (#158) * [fix] add condition check back * Fix CI syntax issue * Cenevan demo (#195) * Create test-slack-notifs.yml * Update test-slack-notifs.yml * Update test-slack-notifs.yml (#196) * Changed description and title for demo (#197) * Update test-slack-notifs.yml * Update test-slack-notifs.yml * Update publish-package.yml (#193) * Update publish-package.yaml * Update publish-package.yaml * Update publish-package.yaml * reusable slack workflow implemented * Update publish-package.yaml (#211) * Update publish-package.yaml (#217) * Bump up react sdk to 0.0.1 * Make react-sdk test's timeout longer * Update publish-package.yaml * Update @story-protocol/[email protected] in react sdk * Fix nonce issue when run integration test * Update style when run npm run generate command * Skip test about Non-Commercial Remix * Upgrade pnpm/action-setup version --------- Co-authored-by: Andy Wu <[email protected]> Co-authored-by: Ze <[email protected]> Co-authored-by: cenevan <[email protected]>
Description
GHA Job to send notification to Slack Once Package Published to NPM Registry
Related Issue
#187
Summary by CodeRabbit