refactor client config to use chainId string #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonFungible
had a problem deploying
to
alpha-sepolia
GitHub Actions
Failure
DonFungible
had a problem deploying
to
alpha-sepolia
GitHub Actions
Failure
DonFungible
had a problem deploying
to
alpha-sepolia
GitHub Actions
Failure
DonFungible
temporarily deployed
to
alpha-sepolia
GitHub Actions
Inactive
edisonz0718
approved these changes
Jan 8, 2024
DonFungible
had a problem deploying
to
beta-sepolia
GitHub Actions
Failure
DonFungible
had a problem deploying
to
beta-sepolia
GitHub Actions
Failure
DonFungible
had a problem deploying
to
beta-sepolia
GitHub Actions
Failure
DonFungible
temporarily deployed
to
beta-sepolia
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes viem version dependency and improves DevEx by accepting a chainId string instead of a chain object.
Previously we had to pass in a chain object when instantiating the StoryClient object. However the chain object can be different depending on what version viem is.