Merge pull request #246 from storyprotocol/dev

Bp/sdk pr 4 (#245)
storyprotocol · Aug 30, 2024 · 9bff31f · 9bff31f
2 parents 6c4e04f + 972539a
commit 9bff31f
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 4 deletions.
diff --git a/packages/core-sdk/package.json b/packages/core-sdk/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@story-protocol/core-sdk",
-  "version": "1.0.0-rc.20",
+  "version": "1.0.0-rc.21",
   "description": "Story Protocol Core SDK",
   "main": "dist/story-protocol-core-sdk.cjs.js",
   "module": "dist/story-protocol-core-sdk.esm.js",

diff --git a/packages/core-sdk/src/index.ts b/packages/core-sdk/src/index.ts
@@ -25,6 +25,8 @@ export type {
   RegisterIpAndAttachPilTermsRequest,
   RegisterIpAndAttachPilTermsResponse,
   MintAndRegisterIpAndMakeDerivativeRequest,
+  IpCreator,
+  IpMetadata,
 } from "./types/resources/ipAsset";
 
 export type {

diff --git a/packages/core-sdk/src/types/resources/ipAsset.ts b/packages/core-sdk/src/types/resources/ipAsset.ts
@@ -58,7 +58,6 @@ export type CreateIpAssetWithPilTermsRequest = {
   mintingFee?: string | number | bigint;
   recipient?: Address;
   commercialRevShare?: number;
-  nftMetadata?: string;
 } & IpMetadataAndTxOption;
 
 export type CreateIpAssetWithPilTermsResponse = {
@@ -110,7 +109,6 @@ export type MintAndRegisterIpAndMakeDerivativeRequest = {
     licenseTermsIds: string[] | bigint[] | number[];
     licenseTemplate?: Address;
   };
-  nftMetadata?: string;
   recipient?: Address;
 } & IpMetadataAndTxOption;
 

diff --git a/packages/core-sdk/src/utils/getLicenseTermsByType.ts b/packages/core-sdk/src/utils/getLicenseTermsByType.ts
@@ -31,6 +31,7 @@ export function getLicenseTermByType(
     uri: "",
   };
   if (type === PIL_TYPE.NON_COMMERCIAL_REMIX) {
+    licenseTerms.commercializerCheckerData = "0x";
     return licenseTerms;
   } else if (type === PIL_TYPE.COMMERCIAL_USE) {
     if (!term || term.defaultMintingFee === undefined || term.currency === undefined) {

diff --git a/packages/core-sdk/test/unit/utils/getLicenseTermsByType.test.ts b/packages/core-sdk/test/unit/utils/getLicenseTermsByType.test.ts
@@ -13,7 +13,7 @@ describe("Get License Terms By Type", () => {
       commercialRevShare: 0,
       commercialUse: false,
       commercializerChecker: "0x0000000000000000000000000000000000000000",
-      commercializerCheckerData: "0x0000000000000000000000000000000000000000",
+      commercializerCheckerData: "0x",
       currency: "0x0000000000000000000000000000000000000000",
       derivativeRevCeiling: 0n,
       derivativesAllowed: true,