Disable Next.js image optimization #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
✅ Deploy Preview for storybook-frontpage ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for storybook-addon-catalog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This reverts commit 5d880b2.
winkerVSbecks
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabled, either Next.js' image cache or Netlify's image CDN either serves a broken image or the incorrect one.
Notes from my investigation:
Netlify's Next.js framework docs say it should "just work":
But given that the deployed img srcs still look like
/_next/image?url=..., I'm not sure that it's working for us? The Image CDN docs state that the src would be/.netlify/images?url=.... I suppose that framework could set up a proxy rewrite from the former URL to the latter, but I don't know how to confirm that.Well, I found their Next.js framework's source, and it contains a function that does appear to set up exactly that proxy rewrite:
https://github.com/netlify/next-runtime/blob/main/src/build/image-cdn.ts