Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes necessary to move onto Netlify #224

Merged
merged 15 commits into from
Sep 4, 2024
Merged

Changes necessary to move onto Netlify #224

merged 15 commits into from
Sep 4, 2024

Conversation

cdedreuille
Copy link
Collaborator

@cdedreuille cdedreuille commented Aug 30, 2024 •
edited by kylegach
Loading

We should strive to not break Vercel deployments while doing so.

Issues

To QA

  • Analytics

QA'd

@vercel Vercel
Copy link

vercel bot commented Aug 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 9:59pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
web-addon-catalog ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 9:59pm

@netlify Netlify
Copy link

netlify bot commented Aug 30, 2024 •
edited
Loading

✅ Deploy Preview for storybook-frontpage ready!

Name Link
🔨 Latest commit 8f1914f
🔍 Latest deploy log https://app.netlify.com/sites/storybook-frontpage/deploys/66d8d73a94512500081a0f83
😎 Deploy Preview https://deploy-preview-224--storybook-frontpage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Aug 30, 2024 •
edited
Loading

✅ Deploy Preview for storybook-addon-catalog ready!

Name Link
🔨 Latest commit 8f1914f
🔍 Latest deploy log https://app.netlify.com/sites/storybook-addon-catalog/deploys/66d8d73a7d8e1b0008ec7a8c
😎 Deploy Preview https://deploy-preview-224--storybook-addon-catalog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kylegach
kylegach previously requested changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comment.

apps/frontpage/_redirects Outdated Show resolved Hide resolved
@kylegach kylegach dismissed their stale review August 30, 2024 17:12

Changes were made

@kylegach kylegach changed the title Create _redirects for Netlify Changes necessary to move onto Netlify Sep 3, 2024
@vercel vercel bot temporarily deployed to Preview – web September 3, 2024 17:24 Inactive
kylegach
kylegach approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@kylegach kylegach merged commit 8ae4f2e into main Sep 4, 2024
12 checks passed
@kylegach kylegach deleted the netlify-rewrites branch September 4, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylegach kylegach kylegach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdedreuille @kylegach