Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Define test function as early as possible #445

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Mar 26, 2024

Closes #68

What I did

Attempt on fixing #68 by injecting the __test script as early as possible

Checklist for Contributors

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes in this repository
  • Request documentation updates in the test-runner docs website

Checklist for Maintainers

  • Make sure this PR contains one of the labels below:

    Available labels
    • skip-release: Skip any releases, e.g., documentation only changes, CI config etc.
    • patch: Upgrade patch version (e.g. 0.0.x)
    • minor: Upgrade patch version (e.g. 0.x.0)
    • major: Upgrade patch version (e.g. x.0.0)
📦 Published PR as canary version: 0.17.1--canary.445.4041ab4.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@yannbf yannbf added the patch Increment the patch version when merged label Mar 26, 2024
@yannbf yannbf requested a review from kasperpeulen as a code owner March 26, 2024 11:09
@j0sk
Copy link

j0sk commented Dec 3, 2024

With this patch I was able to resolve "__test in not defined" errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]ReferenceError: __test is not defined
2 participants