Build: Revert Downgrade to esbuild 0.24.0 #30120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -83,7 +83,7 @@ | |||
| "@types/babel__traverse@npm:^7.18.0": "patch:@types/babel__traverse@npm%3A7.20.6#~/.yarn/patches/@types-babel__traverse-npm-7.20.6-fac4243243.patch", | |||
| "@types/node": "^22.0.0", | |||
| "@vitest/expect@npm:2.0.5": "patch:@vitest/expect@npm%3A2.0.5#~/.yarn/patches/@vitest-expect-npm-2.0.5-8933466cce.patch", | |||
| "esbuild": "0.24.0", | |||
| "esbuild": "^0.24.0", | |||
There was a problem hiding this comment.
logic: Making esbuild resolution less strict could reintroduce CI instability that the original PR fixed
| @@ -54,7 +54,7 @@ | |||
| ] | |||
| }, | |||
| "resolutions": { | |||
| "esbuild": "0.24.0", | |||
| "esbuild": "^0.24.0", | |||
There was a problem hiding this comment.
logic: changing from fixed to caret version may reintroduce original CI issues that prompted the downgrade
|
View your CI Pipeline Execution ↗ for commit 63423fd.
☁️ Nx Cloud last updated this comment at |
valentinpalkovic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #30116
Greptile Summary
This PR reverts a previous downgrade of esbuild dependency, restoring more flexible version constraints across multiple package.json files in the Storybook monorepo.
0.24.0to^0.24.0incode/package.jsonresolutionscode/core/package.jsonto allow patch updates within 0.24.xscripts/package.jsonto use caret range instead of fixed version