Fix angular accent character issue #30114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+165
to
+166
| const accentCharacters = /[\u0300-\u036f]/g; | ||
| return rawStoryUid.normalize('NFD').replace(accentCharacters, ''); |
There was a problem hiding this comment.
style: Consider using a more comprehensive Unicode range to handle other types of diacritical marks and special characters that could cause similar issues
Comment on lines
+161
to
+163
| if (rawStoryUid === null) { | ||
| return rawStoryUid; | ||
| } |
There was a problem hiding this comment.
style: Consider adding a trim() call to handle potential whitespace issues that could affect selectors
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29132
What I did
Just filtered accent characters from a story UID, as suggested at #29132 (comment).
The method defined in this PR could convert
Example/Button with an "é" accentintoExample/Button with an "e" accent.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
I'll provide a concise summary of the changes in this PR focusing on the Angular accent character fix:
Added normalization of accented characters in Angular component selectors to prevent NG05104 errors when using accented characters in story titles.
generateStoryUIdFromRawStoryUidmethod incode/frameworks/angular/src/client/angular-beta/AbstractRenderer.tsto handle accent normalizationgenerateTargetSelectorFromStoryIdmethodThe changes are focused and minimal, addressing a specific issue with accented characters in Angular component selectors while following established patterns in the codebase.
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!