Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddonTest: Improve error reporting #30110

Open
wants to merge 7 commits into
base: next
Choose a base branch
from
Open

AddonTest: Improve error reporting #30110

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2534d0b
fix problem where incoreect testCount was displayed when there are gl…
ndelangen Dec 19, 2024
5856a8b
Merge branch 'next' into norbert/improve-test-global-error-handling
ndelangen Dec 19, 2024
823e2f7
rename
ndelangen Dec 19, 2024
67a3ac3
Merge branch 'norbert/improve-test-global-error-handling' of https://…
ndelangen Dec 19, 2024
b8ad38b
correct logic mistake
ndelangen Dec 20, 2024
a4bc581
Merge branch 'next' into norbert/improve-test-global-error-handling
ndelangen Dec 20, 2024
12a10c5
Merge branch 'next' into norbert/improve-test-global-error-handling
ndelangen Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 36 additions & 19 deletions code/addons/test/src/node/reporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,41 +213,58 @@ export class StorybookReporter implements Reporter {
async onFinished() {
const unhandledErrors = this.ctx.state.getUnhandledErrors();

const isCancelled = this.ctx.isCancelling;
const report = await this.getProgressReport(Date.now());

const testSuiteFailures = report.details.testResults.filter(
(t) => t.status === 'failed' && t.results.length === 0
);

const reducedTestSuiteFailures = new Set<string>();
const deduplicatedTestSuiteFailures = new Set<string>();

testSuiteFailures.forEach((t) => {
reducedTestSuiteFailures.add(t.message);
deduplicatedTestSuiteFailures.add(t.message);
});

const isCancelled = this.ctx.isCancelling;
const hasTestSuiteFailures = deduplicatedTestSuiteFailures.size > 0;
const hasUnhandledErrors = unhandledErrors.length > 0;

if (isCancelled) {
this.sendReport({
providerId: TEST_PROVIDER_ID,
status: 'cancelled',
...report,
});
} else if (reducedTestSuiteFailures.size > 0 || unhandledErrors.length > 0) {
const error =
reducedTestSuiteFailures.size > 0
? {
name: `${reducedTestSuiteFailures.size} component ${reducedTestSuiteFailures.size === 1 ? 'test' : 'tests'} failed`,
message: Array.from(reducedTestSuiteFailures).reduce(
(acc, curr) => `${acc}\n${curr}`,
''
),
}
: {
name: `${unhandledErrors.length} unhandled error${unhandledErrors?.length > 1 ? 's' : ''}`,
message: unhandledErrors
.map((e, index) => `[${index}]: ${(e as any).stack || (e as any).message}`)
.join('\n----------\n'),
};
} else if (hasTestSuiteFailures || hasUnhandledErrors) {
const isMultipleSuiteFailures = testSuiteFailures.length === 1;
ndelangen marked this conversation as resolved.
Show resolved Hide resolved
const isMultipleDeduplicatedTestSuitesFailures = deduplicatedTestSuiteFailures.size > 1;
const isMultipleUnhandledErrors = unhandledErrors?.length > 1;

let error: { name: string; message: string };

if (hasTestSuiteFailures && hasUnhandledErrors) {
error = {
name: `${testSuiteFailures.length} component test${isMultipleSuiteFailures ? 's' : ''} failed, due to ${deduplicatedTestSuiteFailures.size} runtime error${isMultipleDeduplicatedTestSuitesFailures ? 's' : ''} as well as ${unhandledErrors.length} unhandled error${isMultipleUnhandledErrors ? 's' : ''}`,
message: [
...Array.from(deduplicatedTestSuiteFailures),
...unhandledErrors.map(
(e, index) => `[${index}]: ${(e as any).stack || (e as any).message}`
),
].join('\n----------\n'),
};
} else if (hasTestSuiteFailures) {
error = {
name: `${testSuiteFailures.length} component test${isMultipleSuiteFailures ? 's' : ''} failed, due to ${deduplicatedTestSuiteFailures.size} runtime error${isMultipleDeduplicatedTestSuitesFailures ? 's' : ''}`,
message: Array.from(deduplicatedTestSuiteFailures).join('\n----------\n'),
};
} else {
error = {
name: `${unhandledErrors.length} unhandled error${isMultipleUnhandledErrors ? 's' : ''}`,
message: unhandledErrors
.map((e, index) => `[${index}]: ${(e as any).stack || (e as any).message}`)
.join('\n----------\n'),
};
}

this.sendReport({
providerId: TEST_PROVIDER_ID,
Expand Down
Loading