Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Test: Context menu updates #30107

Open
wants to merge 6 commits into
base: next
Choose a base branch
from
Open

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Dec 19, 2024

What I did

  • Removed the edit mode toggle from the context menu because config is always global.
  • Removed coverage from the context menu, as we only support global coverage.
  • Swapped coverage and a11y in the testing module for consistency with the context menu (where we no longer have coverage).
  • Added tooltip notes to buttons that have no label.
  • Updated the title and description to be specific to the current entry rather than the global state.
  • Made pending status dot glow.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.8 MB 77.8 MB 0 B 2.38 0%
initSize 133 MB 133 MB 1.07 kB -3 0%
diffSize 55.3 MB 55.3 MB 1.07 kB -3 0%
buildSize 7.23 MB 7.23 MB 1.07 kB -1.71 0%
buildSbAddonsSize 1.86 MB 1.86 MB 0 B -2 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.87 MB 1.87 MB 1.07 kB 2.1 0.1%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.92 MB 3.92 MB 1.07 kB -1.71 0%
buildPreviewSize 3.3 MB 3.3 MB 0 B -0.43 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 17.7s 18s 291ms 0.46 1.6%
generateTime 20.7s 22.2s 1.4s 1.02 6.7%
initTime 14.6s 15s 455ms 0.41 3%
buildTime 8.4s 8.7s 274ms -0.88 3.1%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.3s 4.3s -1s -941ms -1.42 🔰-44.5%
devManagerResponsive 4.9s 3.4s -1s -509ms -1.13 -44%
devManagerHeaderVisible 657ms 557ms -100ms -1.04 -18%
devManagerIndexVisible 691ms 572ms -119ms -1.14 -20.8%
devStoryVisibleUncached 2s 1.1s -926ms -1.85 🔰-79.3%
devStoryVisible 693ms 593ms -100ms -1.02 -16.9%
devAutodocsVisible 648ms 494ms -154ms -0.84 -31.2%
devMDXVisible 580ms 459ms -121ms -1.16 -26.4%
buildManagerHeaderVisible 735ms 518ms -217ms -1.17 -41.9%
buildManagerIndexVisible 829ms 608ms -221ms -1.14 -36.3%
buildStoryVisible 697ms 509ms -188ms -1.06 -36.9%
buildAutodocsVisible 655ms 412ms -243ms -0.84 -59%
buildMDXVisible 637ms 406ms -231ms -1.16 -56.9%

Greptile Summary

Based on the provided information, I'll create a concise summary of the changes to the TestProviderRender component in the Storybook addon-test module.

Updates TestProviderRender component to improve UI consistency and clarify configuration scope by adjusting menu options and their display order.

  • Removes edit mode toggle from context menu since configuration is always global (!entryId condition)
  • Relocates coverage section after accessibility section for consistent ordering across edit/view modes
  • Restricts coverage display to global level only by adding !entryId conditions
  • Maintains core functionality while improving UI organization and clarity

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Dec 19, 2024

View your CI Pipeline Execution ↗ for commit 6aabe37.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 35s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-20 16:07:23 UTC

@storybook-pr-benchmarking
Copy link

storybook-pr-benchmarking bot commented Dec 19, 2024

Package Benchmarks

Commit: 6aabe37, ran on 20 December 2024 at 16:14:28 UTC

No significant changes detected, all good. 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants