Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vitest: Add plugins from
viteFinal
#30105base: next
Are you sure you want to change the base?
Vitest: Add plugins from
viteFinal
#30105Changes from 14 commits
4fdafc1
5110c71
a079a28
8bc928b
89036fe
2259584
4bce136
20f5254
c38eed3
470c04c
21873f1
4512a5a
a045f4e
5bb9a7f
e1cd01a
2e1ad63
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: filtering out docgen plugins could miss important plugins needed by some frameworks - needs thorough testing across all frameworks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before, this preset would discard any config set by previous
viteFinal
presets. We never noticed it because this would always run first in Storybook. But in the Vitest plugin it appears thatmain.ts
runs first, so we need to handle it properly here.