feat: add eject button to canvas toolbar #29825
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| storyId={getStoryId(getChildProps(children), context)} | ||
| baseUrl="./iframe.html" | ||
| /> |
There was a problem hiding this comment.
style: baseUrl is hardcoded to './iframe.html' which may not be correct in all environments. Consider making this configurable via context or props.
There was a problem hiding this comment.
Does the baseUrl here need similar improvements as #12233?
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d5c7e81. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Closes #25123
What I did
Added the eject button back to Canvas toolbar in docs mode.
I think one future improvement could be to add controls integration to the primary story, as right now it opens with no params applied. But even so, this would be a nice upgrade for our usecases.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Not sure how these blocks are autotested at all. If you can point me in the right direction, I can look into adding tests.
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
yarn startsandbox/react-vite-default-ts/.storybook/preview.tsto enable toolbar on all stories (docs: { canvas: { withToolbar: true } })Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Added an "Open canvas in new tab" button to the Canvas toolbar in docs mode, restoring previously missing functionality from issue #25123.
ShareAltIconbutton incode/lib/blocks/src/components/Toolbar.tsxthat opens story in new tabEjectPropsinterface inToolbar.tsxto handlestoryIdandbaseUrlpropsPreview.tsxto pass story context and ID to Toolbar componenttarget="_blank"andrel="noopener noreferrer"💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!