Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test addon: Interaction testing → Component testing #29568

Open
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

kylegach
Copy link
Contributor

@kylegach kylegach commented Nov 7, 2024

What I did

  • Update empty state for Test and Interactions addon panel
  • Update CLI template comment

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Open Storybook in your browser
  3. Access a story without a play function
  4. Repeat those steps for a sandbox without the Test addon installed?

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 78.2 MB 78.2 MB 148 B 0.83 0%
initSize 143 MB 143 MB 1.76 kB 1.25 0%
diffSize 65.2 MB 65.2 MB 1.61 kB 4.43 0%
buildSize 6.88 MB 6.88 MB -7 B 0.52 0%
buildSbAddonsSize 1.51 MB 1.51 MB -7 B 1.33 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.9 MB 1.9 MB 0 B 0.51 0%
buildSbPreviewSize 271 kB 271 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.88 MB 3.88 MB -7 B 0.52 0%
buildPreviewSize 3 MB 3 MB 0 B 0.5 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 8.7s 21.8s 13.1s 1.19 60.1%
generateTime 25.9s 20.6s -5s -278ms -0.44 -25.5%
initTime 17s 14s -3s -68ms -0.75 -21.9%
buildTime 7.2s 7.7s 515ms -0.95 6.6%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 4.9s 6.1s 1.1s 0.55 19.3%
devManagerResponsive 3.1s 3.6s 579ms 0.31 15.7%
devManagerHeaderVisible 522ms 583ms 61ms 0.38 10.5%
devManagerIndexVisible 581ms 618ms 37ms 0.02 6%
devStoryVisibleUncached 932ms 1s 131ms 0.36 12.3%
devStoryVisible 548ms 617ms 69ms 0.12 11.2%
devAutodocsVisible 421ms 555ms 134ms 0.81 24.1%
devMDXVisible 455ms 569ms 114ms 1.04 20%
buildManagerHeaderVisible 467ms 527ms 60ms -0.27 11.4%
buildManagerIndexVisible 484ms 535ms 51ms -0.35 9.5%
buildStoryVisible 462ms 525ms 63ms -0.29 12%
buildAutodocsVisible 385ms 459ms 74ms 0.48 16.1%
buildMDXVisible 382ms 489ms 107ms 0.64 21.9%

Greptile Summary

Updates terminology from "interaction testing" to "component testing" across Storybook's codebase, affecting empty state components and story templates for all supported frameworks.

  • Modified code/addons/interactions/src/components/EmptyState.tsx and code/addons/test/src/components/EmptyState.tsx to update panel titles and descriptions
  • Updated documentation links from /writing-tests/interaction-testing to /writing-tests/component-testing across all framework templates
  • Removed video tutorial link from test addon empty state, leaving only documentation link
  • Maintained consistent testing functionality while only updating terminology and documentation references

- "Interaction testing" -> "Component testing"
- "Interaction testing" -> "Component testing"
@kylegach kylegach added patch:yes Bugfix & documentation PR that need to be picked to main branch addon: interactions addon: test labels Nov 7, 2024
@kylegach kylegach self-assigned this Nov 7, 2024
Copy link

nx-cloud bot commented Nov 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8230152. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kylegach kylegach changed the title [addon-test]: "Interaction testing" → "Component testing" Test addon: "Interaction testing" → "Component testing" Nov 7, 2024
@kylegach kylegach changed the title Test addon: "Interaction testing" → "Component testing" Test addon: Interaction testing → Component testing Nov 7, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

22 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: interactions addon: test bug ci:normal patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant