Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Benchmark individual package's sizes and dependencies #29356

Merged
Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
03dea27
initial script to bench individual packages
JReinhold Oct 11, 2024
ca5efc0
use node apis instead of CLIs to rm files in run-registry script
JReinhold Oct 11, 2024
4224e79
improve readability
JReinhold Oct 15, 2024
c212880
add circleci job for package benching
JReinhold Oct 15, 2024
a21f321
save results to file
JReinhold Oct 15, 2024
10ec1ed
fix result path
JReinhold Oct 15, 2024
7af86e2
add support for comparing bench results with a base
JReinhold Oct 15, 2024
fcd2d96
cleanup
JReinhold Oct 16, 2024
8a40fd3
start upload benches
JReinhold Oct 16, 2024
738c6bb
upload to BigQuery
JReinhold Oct 17, 2024
caf693a
compare with base branch from bigquery
JReinhold Oct 18, 2024
c99cb88
upload comparisons to github
JReinhold Oct 21, 2024
00be90c
better logging
JReinhold Oct 21, 2024
8b3d1cf
refactor comparison result structure
JReinhold Oct 22, 2024
6af79dd
fix results sent to github
JReinhold Oct 22, 2024
4871e90
use --json for npm install
JReinhold Oct 29, 2024
be33759
compare with zero when package not found in base
JReinhold Oct 29, 2024
de8f3d2
send raw results to github bot
JReinhold Oct 29, 2024
59c4c6b
Merge branch 'next' of github.com:storybookjs/storybook into 29322-se…
JReinhold Oct 29, 2024
76079d0
fix lock-file
JReinhold Oct 29, 2024
aba3a60
Merge branch 'next' into 29322-set-up-tooling-to-warnhighlight-on-reg…
JReinhold Oct 29, 2024
a2a4794
remove auto handling of the registry
JReinhold Oct 29, 2024
d11fb10
Merge branch '29322-set-up-tooling-to-warnhighlight-on-regressions-in…
JReinhold Oct 29, 2024
3aaa3ee
Merge branch 'next' into 29322-set-up-tooling-to-warnhighlight-on-reg…
JReinhold Nov 5, 2024
81a5d07
fix typos
JReinhold Nov 5, 2024
884e9ef
Merge branch '29322-set-up-tooling-to-warnhighlight-on-regressions-in…
JReinhold Nov 5, 2024
a496226
run registry before package benching
JReinhold Nov 7, 2024
fd821a3
wait for local registry
JReinhold Nov 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,25 @@ jobs:
yarn knip --no-exit-code
- report-workflow-on-failure
- cancel-workflow-on-failure
bench-packages:
JReinhold marked this conversation as resolved.
Show resolved Hide resolved
executor:
class: medium
name: sb_node_22_classic
steps:
- git-shallow-clone/checkout_advanced:
clone_options: "--depth 1 --verbose"
- attach_workspace:
at: .
- run:
name: Benchmarking Packages
working_directory: scripts
command: yarn bench-packages --baseBranch << pipeline.parameters.ghBaseBranch >> --pull-request << pipeline.parameters.ghPrNumber >> --upload
JReinhold marked this conversation as resolved.
Show resolved Hide resolved
- store_artifacts:
path: bench/packages/results.json
- store_artifacts:
path: bench/packages/compare-with-<< pipeline.parameters.ghBaseBranch >>.json
- report-workflow-on-failure
- cancel-workflow-on-failure
check:
executor:
class: xlarge
Expand Down Expand Up @@ -543,7 +562,7 @@ jobs:
- store_artifacts: # this is where playwright puts more complex stuff
path: code/playwright-results/
destination: playwright
bench:
bench-sandboxes:
parameters:
parallelism:
type: integer
Expand Down Expand Up @@ -753,6 +772,9 @@ workflows:
- knip:
requires:
- build
- bench-packages:
requires:
- build
- check:
requires:
- build
Expand Down Expand Up @@ -799,7 +821,7 @@ workflows:
parallelism: 5
requires:
- create-sandboxes
- bench:
- bench-sandboxes:
parallelism: 5
requires:
- build-sandboxes
Expand Down Expand Up @@ -828,6 +850,9 @@ workflows:
- knip:
requires:
- build
- bench-packages:
requires:
- build
- check:
requires:
- build
Expand Down Expand Up @@ -883,7 +908,7 @@ workflows:
- test-ui-testing-module:
requires:
- build
- bench:
- bench-sandboxes:
parallelism: 5
requires:
- build-sandboxes
Expand All @@ -904,6 +929,9 @@ workflows:
- knip:
requires:
- build
- bench-packages:
requires:
- build
- check:
requires:
- build
Expand Down Expand Up @@ -977,7 +1005,7 @@ workflows:
# --smoke-test is not supported for the angular builder right now
# - "angular-cli"
- "lit-vite-ts"
- bench:
- bench-sandboxes:
parallelism: 5
requires:
- build-sandboxes
Expand Down
Loading
Loading