-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Code contribution WSL removal #29174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 90c1f79. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tobiasdiez thanks for taking the time to put together this pull request and helping us improve the documentation with the recent changes introduced. Appreciate it 🙏 .
This is shaping up nicely, I left only a couple of small adjustments for you to consider when you can.
Let me know and we'll take it from there.
Have a great day.
Stay safe
Co-authored-by: jonniebigodes <[email protected]>
Co-authored-by: jonniebigodes <[email protected]>
Thanks @jonniebigodes. Your suggestions are a nice improvement. |
@tobiasdiez I'm sorry for the delayed response and for getting this across, but it's been some busy times here at Storybook. I've just updated the branch and am going to merge this one, as you already addressed the feedback. Have a great day. Stay safe |
Closes #
What I did
After the recent changes (in particular the usage of jiti), I have no problems developing on storybook directly from windows, without any need for WSL. Thus this is removed from the developer docs.
However, one does need to run the command for creating the sandbox as admin, since otherwise one gets a permission error when creating the symlinks.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
This PR removes the requirement for Windows users to use Windows Subsystem for Linux (WSL) when developing Storybook, simplifying the setup process.