-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: Prerelease 8.4.0-alpha.1 #29118
base: next-release
Are you sure you want to change the base?
Release: Prerelease 8.4.0-alpha.1 #29118
Conversation
Addon-Interactions: Use ansi-to-html for colored test errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
@@ -135,7 +136,7 @@ export const Exception = ({ exception }: { exception: Call['exception'] }) => { | |||
const more = paragraphs.length > 1; | |||
return ( | |||
<RowMessage> | |||
<pre>{paragraphs[0]}</pre> | |||
<pre dangerouslySetInnerHTML={{ __html: filter.toHtml(paragraphs[0]) }}></pre> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Use of dangerouslySetInnerHTML could pose a security risk if the input is not properly sanitized
dangerouslySetInnerHTML={{ | ||
__html: filter.toHtml(printSerializedError(caughtException)), | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Use of dangerouslySetInnerHTML might pose security risks if the input is not properly sanitized
<span | ||
key={line + index} | ||
dangerouslySetInnerHTML={{ __html: filter.toHtml(line) }} | ||
></span>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Using dangerouslySetInnerHTML can be a security risk if the input is not properly sanitized. Ensure that the filter.toHtml() method properly escapes any potentially malicious content.
VS Code complains about not being able to find Node types, but building the package works. Need to investigate.
VS Code complains about not being able to find Node types, but building the package works. Need to investigate.
Next.js: Upgrade sass-loader from ^12 to ^13
Angular: Fix sourceDecorator to apply excludeDecorators flag
5bd0c95
to
5bbaad1
Compare
…jsdoc-type-pratt-parser Core: Do not prebundle jsdoc-type-pratt-parser
5bbaad1
to
7d1ba90
Compare
…better-opn Core: Do not prebundle better-opn
7d1ba90
to
c8cb610
Compare
Since v10.24.0, Preact pretends to be React version 18.3.1 instead of 17.0.2. This change has caused an assertion failure in one of our E2E tests where we have assumed to see React 17.0.2 printed in one of our stories.
…preact Preact: Fix E2E test
c8cb610
to
f19d4cd
Compare
…tall-installation
Core: Replace `fs-extra` with the native APIs
f19d4cd
to
f760f5a
Compare
…installation CLI: Fix skip-install for stable latest releases
f760f5a
to
7d463e8
Compare
This is an automated pull request that bumps the version from
8.4.0-alpha.0
to8.4.0-alpha.1
.Once this pull request is merged, it will trigger a new release of version
8.4.0-alpha.1
.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next
, that will be part of this release:fs-extra
with the native APIs #29126If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.4.0-alpha.1
fs-extra
with the native APIs - #29126, thanks @ziebam!