Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump express to v^4.21 #29079

Open
wants to merge 7 commits into
base: next
Choose a base branch
from

Conversation

tommasini
Copy link

@tommasini tommasini commented Sep 10, 2024

Closes #

What I did

Hey Storybook team, I have bumped express on the repo to address this audit advisory: GHSA-m6fv-jmcg-4jfg

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.4 MB 77.4 MB 0 B 1.69 0%
initSize 162 MB 162 MB 0 B -0.37 0%
diffSize 84.9 MB 84.9 MB 0 B -0.41 0%
buildSize 7.57 MB 7.57 MB 0 B 0.64 0%
buildSbAddonsSize 1.66 MB 1.66 MB 0 B 0.72 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.34 MB 2.34 MB 0 B 0.65 0%
buildSbPreviewSize 352 kB 352 kB 0 B 0.5 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.55 MB 4.55 MB 0 B 0.72 0%
buildPreviewSize 3.02 MB 3.02 MB 0 B -0.06 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 25.6s 23.2s -2s -443ms 1.59 🔰-10.5%
generateTime 20.2s 19.4s -806ms -1.02 -4.1%
initTime 16.4s 15.9s -403ms -1.06 -2.5%
buildTime 11.6s 11s -601ms -0.58 -5.5%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.4s 6.8s 398ms -0.09 5.8%
devManagerResponsive 4.1s 4.3s 194ms -0.22 4.5%
devManagerHeaderVisible 751ms 981ms 230ms 1.18 23.4%
devManagerIndexVisible 796ms 1s 238ms 1.22 23%
devStoryVisibleUncached 1.3s 1.7s 381ms 1.02 22%
devStoryVisible 797ms 1s 236ms 1.21 22.8%
devAutodocsVisible 700ms 1s 337ms 3.08 🔺32.5%
devMDXVisible 663ms 749ms 86ms 0.17 11.5%
buildManagerHeaderVisible 797ms 784ms -13ms 0.04 -1.7%
buildManagerIndexVisible 798ms 794ms -4ms -0.06 -0.5%
buildStoryVisible 891ms 827ms -64ms -0.09 -7.7%
buildAutodocsVisible 672ms 789ms 117ms 0.67 14.8%
buildMDXVisible 721ms 746ms 25ms 0.59 3.4%

Greptile Summary

This pull request updates the express dependency from version 4.19.2 to 4.20.0 across multiple package.json files in the Storybook repository to address a security advisory.

  • Updated express to ^4.20.0 in five package.json files: builder-vite, builder-webpack5, core, scripts, and server-kitchen-sink
  • Addresses security advisory GHSA-m6fv-jmcg-4jfg, improving overall security
  • Minor version bump, likely to maintain compatibility with existing codebase
  • Consistent change across all affected files, simplifying the update process
  • No other modifications made, focusing solely on the express dependency update

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@tommasini
Copy link
Author

We should bump it again when this change is released on a patch version of express: expressjs/serve-static#176

@tommasini tommasini changed the title bump express to v^4.20 bump express to v^4.21 Sep 13, 2024
@valentinpalkovic valentinpalkovic self-assigned this Sep 16, 2024
@valentinpalkovic valentinpalkovic added bug patch:yes Bugfix & documentation PR that need to be picked to main branch security ci:normal labels Sep 16, 2024
Copy link

nx-cloud bot commented Sep 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 45f3a87. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal patch:yes Bugfix & documentation PR that need to be picked to main branch security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants