Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Avoid crash when theme contains non-color strings #29063

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

Core: Avoid crash when theme contains non-color strings #29063

wants to merge 3 commits into from

Commits on Sep 6, 2024

  1. Avoid crash when theme contains non-color strings 

    This patch fixes runtime crash reported in,

* <#28781>
* <#25092>

This patch skips color modification against theme properties if the
property is color and a value is not valid color strings Polished
accepts. While this wouldn't be exactly what users would expect, program
is usable at least.

I've added two public functions `transparentize` and `opacify` to enable
internal components to access those wrapped ones. I have not added
`@internal` JSDoc tag because:

* that JSDoc tag is not common in this codebase, and
* users would benefit from this.

(I'm not proud of the number of changed files...but this is the minimal
atomic change without losing context I can think of)
    @pocka
    pocka committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    46ee717 View commit details
    Browse the repository at this point in the history

  2. Fix a test using wrong function

    @pocka
    pocka committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    c4cd20b View commit details
    Browse the repository at this point in the history

  3. More tests for theming utility functions

    @pocka
    pocka committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    469b9f8 View commit details
    Browse the repository at this point in the history