Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: "Open canvas in new tab" missing in <Canvas> toolbar #25123

Open
kerryj89 opened this issue Dec 5, 2023 · 5 comments · May be fixed by #29825
Open

[Bug]: "Open canvas in new tab" missing in <Canvas> toolbar #25123

kerryj89 opened this issue Dec 5, 2023 · 5 comments · May be fixed by #29825
Labels
bug sev:S3 ui

Comments

@kerryj89
Copy link

kerryj89 commented Dec 5, 2023

Describe the bug

In the Storybook docs there is an "Open canvas in new tab" button here (see screenshot). I have tried fresh installations and it never appears. I tried looking for the option in the docs to show this action but couldn't find one.

image

To Reproduce

Just do a fresh install of Storybook latest and you'll see that it's missing.

System

Storybook Environment Info:

  System:
    OS: macOS 14.1
    CPU: (10) x64 Apple M1 Pro
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.5.1 - ~/.nvm/versions/node/v20.5.1/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn <----- active
    npm: 9.8.0 - ~/.nvm/versions/node/v20.5.1/bin/npm
  Browsers:
    Chrome: 119.0.6045.199
    Edge: 107.0.1418.52
    Safari: 17.1
  npmPackages:
    @storybook/addon-essentials: ^7.6.3 => 7.6.3 
    @storybook/addon-interactions: ^7.6.3 => 7.6.3 
    @storybook/addon-links: ^7.6.3 => 7.6.3 
    @storybook/addon-onboarding: ^1.0.9 => 1.0.9 
    @storybook/blocks: ^7.6.3 => 7.6.3 
    @storybook/react: ^7.6.3 => 7.6.3 
    @storybook/react-webpack5: ^7.6.3 => 7.6.3 
    @storybook/test: ^7.6.3 => 7.6.3 
    storybook: ^7.6.3 => 7.6.3

Additional context

No response
@shilman
Copy link
Member

shilman commented Dec 25, 2023

Looks like this was removed at some point. @JReinhold @cdedreuille anybody know why?

@jakubbania
Copy link

I have also noticed it missing, "storybook": "7.5.3", can you elaborate how to turn it back on ...or bring it back?

@JReinhold
Copy link
Contributor

JReinhold commented Jan 23, 2024 •
edited
Loading

This was removed on purpose here #19959 but I can't remember why - @tmeasday do you remember?

@tmeasday
Copy link
Member

It says "as discussed". I checked the linear ticket and there's no explicit rationale in there 😞

My best guess was due to the global eject button for the whole page making it duplicative..?

@JReinhold
Copy link
Contributor

My best guess was due to the global eject button for the whole page making it duplicative..?

I see, it wouldn't be an exact duplicate because the global one opens the Docs in a new tab where presumably the eject button in a canvas would open the story.

I think a PR to bring the eject button back would make sense. Maybe it would uncover some technical limitation that was the reason for the initial removal.

@mihkeleidast mihkeleidast linked a pull request Dec 5, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug sev:S3 ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add eject button to canvas toolbar mihkeleidast/storybook
5 participants
@tmeasday @shilman @kerryj89 @JReinhold @jakubbania