Skip to content

Commit

Permalink
Merge pull request #29356 from storybookjs/29322-set-up-tooling-to-wa…
Browse files Browse the repository at this point in the history
…rnhighlight-on-regressions-in-package-size-and-dependency-graph

Build: Benchmark individual package's sizes and dependencies
  • Loading branch information
JReinhold authored Nov 8, 2024
2 parents bf36ba2 + fd821a3 commit f317144
Show file tree
Hide file tree
Showing 5 changed files with 543 additions and 12 deletions.
42 changes: 38 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,31 @@ jobs:
yarn knip --no-exit-code
- report-workflow-on-failure
- cancel-workflow-on-failure
bench-packages:
executor:
class: medium
name: sb_node_22_classic
steps:
- git-shallow-clone/checkout_advanced:
clone_options: "--depth 1 --verbose"
- attach_workspace:
at: .
- run:
name: Benchmarking Packages
working_directory: scripts
command: |
yarn local-registry --open &
until curl -s http://localhost:6001 > /dev/null; do
echo 'Waiting for local registry to be available...'
sleep 2
done
yarn bench-packages --baseBranch << pipeline.parameters.ghBaseBranch >> --pull-request << pipeline.parameters.ghPrNumber >> --upload
- store_artifacts:
path: bench/packages/results.json
- store_artifacts:
path: bench/packages/compare-with-<< pipeline.parameters.ghBaseBranch >>.json
- report-workflow-on-failure
- cancel-workflow-on-failure
check:
executor:
class: xlarge
Expand Down Expand Up @@ -543,7 +568,7 @@ jobs:
- store_artifacts: # this is where playwright puts more complex stuff
path: code/playwright-results/
destination: playwright
bench:
bench-sandboxes:
parameters:
parallelism:
type: integer
Expand Down Expand Up @@ -753,6 +778,9 @@ workflows:
- knip:
requires:
- build
- bench-packages:
requires:
- build
- check:
requires:
- build
Expand Down Expand Up @@ -799,7 +827,7 @@ workflows:
parallelism: 5
requires:
- create-sandboxes
- bench:
- bench-sandboxes:
parallelism: 5
requires:
- build-sandboxes
Expand Down Expand Up @@ -828,6 +856,9 @@ workflows:
- knip:
requires:
- build
- bench-packages:
requires:
- build
- check:
requires:
- build
Expand Down Expand Up @@ -883,7 +914,7 @@ workflows:
- test-ui-testing-module:
requires:
- build
- bench:
- bench-sandboxes:
parallelism: 5
requires:
- build-sandboxes
Expand All @@ -904,6 +935,9 @@ workflows:
- knip:
requires:
- build
- bench-packages:
requires:
- build
- check:
requires:
- build
Expand Down Expand Up @@ -977,7 +1011,7 @@ workflows:
# --smoke-test is not supported for the angular builder right now
# - "angular-cli"
- "lit-vite-ts"
- bench:
- bench-sandboxes:
parallelism: 5
requires:
- build-sandboxes
Expand Down
Loading

0 comments on commit f317144

Please sign in to comment.