cleanup viteFinals

storybookjs · Dec 20, 2024 · e1cd01a · e1cd01a
1 parent 5bb9a7f
commit e1cd01a
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 35 deletions.
diff --git a/code/frameworks/react-native-web-vite/src/preset.ts b/code/frameworks/react-native-web-vite/src/preset.ts
@@ -67,28 +67,25 @@ export const viteFinal: StorybookConfig['viteFinal'] = async (config, options) =
   const { pluginReactOptions = {} } =
     await options.presets.apply<FrameworkOptions>('frameworkOptions');
 
-  const reactConfig = await reactViteFinal(config, options);
+  const { plugins = [], ...reactConfigWithoutPlugins } = await reactViteFinal(config, options);
 
-  const { plugins = [] } = reactConfig;
-
-  plugins.unshift(
-    tsconfigPaths(),
-    flowPlugin({
-      exclude: [/node_modules\/(?!react-native|@react-native)/],
-    }),
-    react({
-      babel: {
-        babelrc: false,
-        configFile: false,
-      },
-      jsxRuntime: 'automatic',
-      ...pluginReactOptions,
-    })
-  );
-
-  plugins.push(reactNativeWeb());
-
-  return mergeConfig(reactConfig, {
+  return mergeConfig(reactConfigWithoutPlugins, {
+    plugins: [
+      tsconfigPaths(),
+      flowPlugin({
+        exclude: [/node_modules\/(?!react-native|@react-native)/],
+      }),
+      react({
+        babel: {
+          babelrc: false,
+          configFile: false,
+        },
+        jsxRuntime: 'automatic',
+        ...pluginReactOptions,
+      }),
+      ...plugins,
+      reactNativeWeb(),
+    ],
     optimizeDeps: {
       esbuildOptions: {
         plugins: [esbuildFlowPlugin(new RegExp(/\.(flow|jsx?)$/), (_path: string) => 'jsx')],

diff --git a/code/frameworks/sveltekit/src/plugins/mock-sveltekit-stores.ts b/code/frameworks/sveltekit/src/plugins/mock-sveltekit-stores.ts
@@ -7,7 +7,7 @@ import type { Plugin } from 'vite';
 const filename = __filename ?? fileURLToPath(import.meta.url);
 const dir = dirname(filename);
 
-export async function mockSveltekitStores() {
+export function mockSveltekitStores() {
   return {
     name: 'storybook:sveltekit-mock-stores',
     config: () => ({

diff --git a/code/frameworks/sveltekit/src/preset.ts b/code/frameworks/sveltekit/src/preset.ts
@@ -25,17 +25,16 @@ export const previewAnnotations: PresetProperty<'previewAnnotations'> = (entry =
 export const viteFinal: NonNullable<StorybookConfig['viteFinal']> = async (config, options) => {
   const baseConfig = await svelteViteFinal(config, options);
 
-  let { plugins = [] } = baseConfig;
-
-  // disable specific plugins that are not compatible with Storybook
-  plugins = (
-    await withoutVitePlugins(plugins, [
-      'vite-plugin-sveltekit-compile',
-      'vite-plugin-sveltekit-guard',
-    ])
-  )
-    .concat(configOverrides())
-    .concat(await mockSveltekitStores());
-
-  return { ...baseConfig, plugins };
+  return {
+    ...baseConfig,
+    plugins: [
+      // disable specific plugins that are not compatible with Storybook
+      ...(await withoutVitePlugins(baseConfig.plugins ?? [], [
+        'vite-plugin-sveltekit-compile',
+        'vite-plugin-sveltekit-guard',
+      ])),
+      configOverrides(),
+      mockSveltekitStores(),
+    ],
+  };
 };